[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on a change in pull request #3868: [FIX_BUG_1.3#3789][remote]support netty heart beat

[GitBox <gi...@apache.org>]

CalvinKirs commented on a change in pull request #3868:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3868#discussion_r502740539



##########
File path: dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/handler/NettyClientHandler.java
##########
@@ -175,4 +183,16 @@ public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws E
         ctx.channel().close();
     }
 
+    @Override
+    public void userEventTriggered(ChannelHandlerContext ctx, Object evt) throws Exception {
+        if (evt instanceof IdleStateEvent) {
+            Command heartBeat = new Command();

Review comment:
       As far as heartbeat detection is concerned, this seems to be redundant. Regardless of the read and write events, they are all the same events. What do you think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org