You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Piotr Zalewa <pz...@mozilla.com> on 2014/11/26 16:28:35 UTC
Notification in dialog plugin
Hi
I came across an issue in writing a Notification support in Cordova.
Dialogs plugin uses Notification for a classy object. I think it should
be called Dialog or similar and not take the Notification. I actually
think the navigator.notifications is wrong name either, that however
might hold a bigger impact on users currently using it.
Should we change this?
--
Piotr Zalewa
Mozilla
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: Notification in dialog plugin
Posted by Michal Mocny <mm...@chromium.org>.
+1, I think we shouldn't change the navigator.notifications interface, but
the name of the internal type is unlikely to break anyone. Can do a major
version bump on the plugin just in case.
-Michal
On Wed, Nov 26, 2014 at 11:07 AM, Brian LeRoux <b...@brian.io> wrote:
> ya this is legacy pain; the source formerly known as phonegap predates
> push/local notifications!
>
> used to be vibrate, flash indicator lights (remember those on
> blackberries?) and beep (also lol)
>
> we named the plugin repo cordova-plugin-dialogue (and moved vibrate out)
> b/c that seemed more appropriate for alert, confirm and friends.
>
> since everything is independently revision-ed in plugins now I say:
> refactor with impunity.
>
> On Wed, Nov 26, 2014 at 7:28 AM, Piotr Zalewa <pz...@mozilla.com> wrote:
>
> > Hi
> >
> > I came across an issue in writing a Notification support in Cordova.
> > Dialogs plugin uses Notification for a classy object. I think it should
> be
> > called Dialog or similar and not take the Notification. I actually think
> > the navigator.notifications is wrong name either, that however might
> hold a
> > bigger impact on users currently using it.
> >
> > Should we change this?
> > --
> > Piotr Zalewa
> > Mozilla
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> >
>
Re: Notification in dialog plugin
Posted by Brian LeRoux <b...@brian.io>.
ya this is legacy pain; the source formerly known as phonegap predates
push/local notifications!
used to be vibrate, flash indicator lights (remember those on
blackberries?) and beep (also lol)
we named the plugin repo cordova-plugin-dialogue (and moved vibrate out)
b/c that seemed more appropriate for alert, confirm and friends.
since everything is independently revision-ed in plugins now I say:
refactor with impunity.
On Wed, Nov 26, 2014 at 7:28 AM, Piotr Zalewa <pz...@mozilla.com> wrote:
> Hi
>
> I came across an issue in writing a Notification support in Cordova.
> Dialogs plugin uses Notification for a classy object. I think it should be
> called Dialog or similar and not take the Notification. I actually think
> the navigator.notifications is wrong name either, that however might hold a
> bigger impact on users currently using it.
>
> Should we change this?
> --
> Piotr Zalewa
> Mozilla
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>