[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6413: add global setting to allow parallel execution on vmware

[GitBox <gi...@apache.org>]

DaanHoogland commented on code in PR #6413:
URL: https://github.com/apache/cloudstack/pull/6413#discussion_r886493841


##########
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java:
##########
@@ -1557,8 +1557,9 @@ public boolean getExecuteInSequence(final HypervisorType hypervisorType) {
             case LXC:
                 return false;
             case VMware:
-                final Boolean fullClone = HypervisorGuru.VmwareFullClone.value();
-                return fullClone;
+                final Boolean fullClone = getFullCloneConfiguration();
+                final Boolean allowParallel = getAllowParallelExecutionConfiguration();
+                return fullClone && !allowParallel;

Review Comment:
   @nvazquez @sureshanaparti @andrijapanicsb @rohityadavcloud any opinions on this? I think it is not harmfull but on the other hand formally wrong. I can see the point but feel that if we have no user asking for fine tuning this we shouldn´t bother. cc @weizhouapache 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org