You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Coding-Alchemist-Abhijay (via GitHub)" <gi...@apache.org> on 2025/12/23 08:15:29 UTC
[PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Coding-Alchemist-Abhijay opened a new pull request, #59744:
URL: https://github.com/apache/airflow/pull/59744
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
-->
---
### What this PR does
This PR adds an end-to-end (E2E) Playwright test to verify that the DAG source
code is correctly displayed in the **Code** tab on the DAG detail page.
The test logs in, navigates to a DAG detail view, opens the Code tab, and asserts
that the DAG code container is visible and rendered. This helps prevent UI
regressions related to DAG code rendering in the Airflow UI.
### Related issue
Closes #59546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi closed pull request #59744: test(e2e): verify DAG code is displayed in Code tab
URL: https://github.com/apache/airflow/pull/59744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3714458495
> > @Coding-Alchemist-Abhijay did you get a chance to fix the review comment?
>
> Hi @vatsrahul1001 , sorry for the delay in addressing this.
>
> I tried my best to cleanly address and fix all the review comments you mentioned (removing explicit login due to auth sharing, avoiding non-existent selectors, following the page object pattern, and adding a proper assertion for DAG code visibility.
>
> I spent some time trying to run the UI E2E tests locally so I could properly validate and debug the failure around getByRole("tab", { name: "Code" }). Unfortunately, I ran into multiple issues setting up Airflow locally on my Windows environment. At different points, my WSL/bash environment broke, and I also faced Breeze-related issues (Docker/Breeze commands failing or not being recognized), which prevented me from getting a stable local setup to iterate on the test.
>
> From reviewing the behavior and the UI implementation, the failure does not seem to be with the Code tab itself, but rather with the selector. getByRole("tab", { name: "Code" }) relies on ARIA roles and accessible names, which may not be immediately available or consistent during initial render/hydration. Because of that, the selector can fail even when the Code tab is visibly present and functional in the UI.
>
> Being able to run Airflow locally would have allowed me to confirm the exact timing/ARIA behavior and adjust the selector accordingly, but I wasn’t able to get a working local setup despite several attempts. I’m still learning the Airflow + Breeze workflow on Windows, and I apologize for the delay this caused.
>
> If you have suggestions on how best to handle or stabilize the getByRole("tab", { name: "Code" }) selector in this context, I’d really appreciate the guidance and will be happy to update the test accordingly.
>
> Thanks for your patience and for the review.
@Coding-Alchemist-Abhijay Thanks for fixes. I have added review comments That should help with you concerns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3920659197
@Coding-Alchemist-Abhijay can you resolve review comments and failing tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-4201275602
Duplicate of https://github.com/apache/airflow/pull/62290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3753037440
@Coding-Alchemist-Abhijay can you take a look at failing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3728122845
@Coding-Alchemist-Abhijay All 5 tests are failing in CI (Chromium, Firefox, WebKit) with below error, are you sure attribute `data-testid="dag-code-content` is available if not I suggest you to add
```
TimeoutError: locator.waitFor: Timeout 10000ms exceeded.
Call log:
- waiting for getByTestId('dag-code-content').locator('.view-lines').first() to be visible
```
Also static checks are failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on code in PR #59744:
URL: https://github.com/apache/airflow/pull/59744#discussion_r2664694797
##########
airflow-core/src/airflow/ui/tests/e2e/specs/dags-list.spec.ts:
##########
@@ -75,7 +75,7 @@ test.describe("Dag Details Tab", () => {
let dagsPage: DagsPage;
const testDagId = testConfig.testDag.id;
-
+
Review Comment:
Unrelated whitespace change here
##########
airflow-core/src/airflow/ui/tests/e2e/pages/DagsPage.ts:
##########
@@ -100,6 +100,27 @@ export class DagsPage extends BasePage {
await this.navigateTo(DagsPage.getDagDetailUrl(dagName));
}
+ /**
+ * Open the Code tab on a DAG detail page
+ */
+ public async openCodeTab(): Promise<void> {
+ const codeTab = this.page
+ .getByRole("tab", { name: "Code" });
+
+ await codeTab.waitFor({ state: "visible", timeout: 10_000 });
+ await codeTab.click();
+ }
+
+ /**
+ * Get the DAG code text displayed in the Code tab
+ */
+ public async getDagCodeText(): Promise<string | null> {
+ const codeBlock = this.page.locator("pre").first();
Review Comment:
This looks fragile. Check if the Code tab component has a data-testid. If not, consider adding one to the UI.
##########
airflow-core/src/airflow/ui/tests/e2e/specs/dag-code-tab.spec.ts:
##########
@@ -0,0 +1,40 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+ import { test, expect } from "@playwright/test";
+ import { DagsPage } from "tests/e2e/pages/DagsPage";
+
+ test.describe("Dag Code Tab", () => {
+ let dagsPage: DagsPage;
+ const testDagId = "example_simplest_dag";
Review Comment:
Get example dag from config instead
```
import { testConfig } from "playwright.config";
const testDagId = testConfig.testDag.id;
```
##########
airflow-core/src/airflow/ui/tests/e2e/pages/DagsPage.ts:
##########
@@ -100,6 +100,27 @@ export class DagsPage extends BasePage {
await this.navigateTo(DagsPage.getDagDetailUrl(dagName));
}
+ /**
+ * Open the Code tab on a DAG detail page
+ */
+ public async openCodeTab(): Promise<void> {
Review Comment:
You can do url navigation which can be more reliable
```
public async openCodeTab(dagId: string): Promise<void> {
await this.page.goto(`/dags/${dagId}/code`);
await this.page.waitForLoadState("networkidle");
}
```
##########
airflow-core/src/airflow/ui/tests/e2e/specs/dag-code-tab.spec.ts:
##########
@@ -0,0 +1,40 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+ import { test, expect } from "@playwright/test";
+ import { DagsPage } from "tests/e2e/pages/DagsPage";
+
+ test.describe("Dag Code Tab", () => {
+ let dagsPage: DagsPage;
+ const testDagId = "example_simplest_dag";
+
+ test.beforeEach(async ({ page }) => {
+ dagsPage = new DagsPage(page);
+ });
+
+ test("should display Dag code", async () => {
Review Comment:
Rename to `verify Dag code displays`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3689367869
Thanks for the PR @Coding-Alchemist-Abhijay, I will review it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3764856943
For the comments, you may mark the ones that have already been addressed as resolved.
This would help reviewers better follow the review flow ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3808925938
> @Coding-Alchemist-Abhijay tests are failing can you have a look?
@Coding-Alchemist-Abhijay how are we progressing on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "Coding-Alchemist-Abhijay (via GitHub)" <gi...@apache.org>.
Coding-Alchemist-Abhijay commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3710111500
> @Coding-Alchemist-Abhijay did you get a chance to fix the review comment?
Hi @vatsrahul1001 ,
sorry for the delay in addressing this.
I spent some time trying to run the UI E2E tests locally so I could properly validate and debug the failure around
getByRole("tab", { name: "Code" }). Unfortunately, I ran into multiple issues setting up Airflow locally on my Windows environment. At different points, my WSL/bash environment broke, and I also faced Breeze-related issues (Docker/Breeze commands failing or not being recognized), which prevented me from getting a stable local setup to iterate on the test.
From reviewing the behavior and the UI implementation, the failure does not seem to be with the Code tab itself, but rather with the selector. getByRole("tab", { name: "Code" }) relies on ARIA roles and accessible names, which may not be immediately available or consistent during initial render/hydration. Because of that, the selector can fail even when the Code tab is visibly present and functional in the UI.
Being able to run Airflow locally would have allowed me to confirm the exact timing/ARIA behavior and adjust the selector accordingly, but I wasn’t able to get a working local setup despite several attempts. I’m still learning the Airflow + Breeze workflow on Windows, and I apologize for the delay this caused.
If you have suggestions on how best to handle or stabilize the getByRole("tab", { name: "Code" }) selector in this context, I’d really appreciate the guidance and will be happy to update the test accordingly.
Thanks for your patience and for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "Coding-Alchemist-Abhijay (via GitHub)" <gi...@apache.org>.
Coding-Alchemist-Abhijay commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3718081770
Hi @vatsrahul1001, I’ve pushed the latest changes and tried to address the points you mentioned in the review. I updated the navigation, cleaned up the selectors, and added the missing test coverage.
Please take another look when you get a chance. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3765623400
@Coding-Alchemist-Abhijay tests are failing can you have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on code in PR #59744:
URL: https://github.com/apache/airflow/pull/59744#discussion_r2649665668
##########
airflow-core/src/airflow/ui/tests/e2e/specs/dag-code-tab.spec.ts:
##########
@@ -0,0 +1,48 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { test, expect } from "@playwright/test";
+import { DagsPage } from "tests/e2e/pages/DagsPage";
+import { LoginPage } from "tests/e2e/pages/LoginPage";
Review Comment:
We do not need login now as we do auth sharing
##########
airflow-core/src/airflow/ui/tests/e2e/pages/DagsPage.ts:
##########
@@ -100,6 +100,29 @@ export class DagsPage extends BasePage {
await this.navigateTo(DagsPage.getDagDetailUrl(dagName));
}
+ /**
+ * Open the Code tab on a DAG detail page
+ */
+public async openCodeTab(): Promise<void> {
+ const codeTab = this.page.locator('[data-testid="dag-code-tab"]');
Review Comment:
I do not think we have any attribute `[data-testid="dag-code-tab"]`. Also we should add all elements in page object(DagsPage.ts )
##########
airflow-core/src/airflow/ui/tests/e2e/specs/dag-code-tab.spec.ts:
##########
@@ -0,0 +1,48 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { test, expect } from "@playwright/test";
+import { DagsPage } from "tests/e2e/pages/DagsPage";
+import { LoginPage } from "tests/e2e/pages/LoginPage";
+import { testConfig } from "playwright.config";
+
+test.describe("DAG Code Tab", () => {
Review Comment:
Lets use Dag Instead of DAG
##########
airflow-core/src/airflow/ui/tests/e2e/specs/dag-code-tab.spec.ts:
##########
@@ -0,0 +1,48 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { test, expect } from "@playwright/test";
+import { DagsPage } from "tests/e2e/pages/DagsPage";
+import { LoginPage } from "tests/e2e/pages/LoginPage";
+import { testConfig } from "playwright.config";
+
+test.describe("DAG Code Tab", () => {
+ let loginPage: LoginPage;
+ let dagsPage: DagsPage;
+ const testCredentials = testConfig.credentials;
+ const testDagId = testConfig.testDag.id;
+
+ test.beforeEach(({ page }) => {
+ loginPage = new LoginPage(page);
+ dagsPage = new DagsPage(page);
+ });
+
+ test("should display DAG code", async () => {
+ await loginPage.navigateAndLogin(testCredentials.username, testCredentials.password);
+ await loginPage.expectLoginSuccess();
+
+ await dagsPage.navigateToDagDetail(testDagId);
+ await dagsPage.openCodeTab();
+
+ const codeContainer = dagsPage.getCodeContainer();
+ await expect(codeContainer).toBeVisible();
+
+ const codeText = await dagsPage.getDagCodeText();
Review Comment:
We should have a assertion here that DAG code is visible
##########
airflow-core/src/airflow/ui/tests/e2e/pages/DagsPage.ts:
##########
@@ -100,6 +100,29 @@ export class DagsPage extends BasePage {
await this.navigateTo(DagsPage.getDagDetailUrl(dagName));
}
+ /**
+ * Open the Code tab on a DAG detail page
+ */
+public async openCodeTab(): Promise<void> {
+ const codeTab = this.page.locator('[data-testid="dag-code-tab"]');
+ await codeTab.waitFor({ state: "visible", timeout: 10_000 });
+ await codeTab.click();
+}
+
+/**
+ * Get the DAG code container (<pre>)
+ */
+public getCodeContainer(): Locator {
+ return this.page.locator('[data-testid="dag-code-container"]');
Review Comment:
I do not think we have any attribute [data-testid="dag-code-container"]. Also we should add all elements in page object(DagsPage.ts )
##########
airflow-core/src/airflow/ui/tests/e2e/specs/dag-code-tab.spec.ts:
##########
@@ -0,0 +1,48 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { test, expect } from "@playwright/test";
+import { DagsPage } from "tests/e2e/pages/DagsPage";
+import { LoginPage } from "tests/e2e/pages/LoginPage";
+import { testConfig } from "playwright.config";
+
+test.describe("DAG Code Tab", () => {
+ let loginPage: LoginPage;
+ let dagsPage: DagsPage;
+ const testCredentials = testConfig.credentials;
+ const testDagId = testConfig.testDag.id;
+
+ test.beforeEach(({ page }) => {
+ loginPage = new LoginPage(page);
+ dagsPage = new DagsPage(page);
+ });
+
+ test("should display DAG code", async () => {
+ await loginPage.navigateAndLogin(testCredentials.username, testCredentials.password);
+ await loginPage.expectLoginSuccess();
+
+ await dagsPage.navigateToDagDetail(testDagId);
+ await dagsPage.openCodeTab();
+
+ const codeContainer = dagsPage.getCodeContainer();
+ await expect(codeContainer).toBeVisible();
+
+ const codeText = await dagsPage.getDagCodeText();
+ console.log("DAG code snippet:", codeText?.slice(0, 100)); // optional debug
Review Comment:
Do we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "Coding-Alchemist-Abhijay (via GitHub)" <gi...@apache.org>.
Coding-Alchemist-Abhijay commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3689809635
> Thanks for the PR @Coding-Alchemist-Abhijay, I will review it soon.
thanks @vatsrahul1001 ! Looking forward to solve more issues!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3693626384
If you’re a Windows user, you can follow the instructions in this section to get set up😉
https://github.com/apache/airflow/blob/main/contributing-docs/03_contributors_quick_start.rst#local-machine-development
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3685665823
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "Coding-Alchemist-Abhijay (via GitHub)" <gi...@apache.org>.
Coding-Alchemist-Abhijay commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3754585146
> @Coding-Alchemist-Abhijay can you take a look at failing tests
Yeah i am constantly looking at the error logs from time to time and trying to fix it !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3885834258
Following from the [conversation](https://github.com/apache/airflow/issues/59028#issuecomment-3885555584) on the E2E test meta issue. I wonder if we can cover all these conditions with unit tests instead of E2E.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "Coding-Alchemist-Abhijay (via GitHub)" <gi...@apache.org>.
Coding-Alchemist-Abhijay commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3818349389
> > @Coding-Alchemist-Abhijay tests are failing can you have a look?
>
> @Coding-Alchemist-Abhijay how are we progressing on this?
Hi @vatsrahul1001 ,
Apologies for the delay — I was tied up with a hackathon over the past few days. I’m back now and actively working on this again. I’m consistently reviewing the CI failures and pushing fixes to address them.
Thanks for your patience, and I appreciate your continued guidance on this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3827986278
> > > @Coding-Alchemist-Abhijay tests are failing can you have a look?
> >
> >
> > @Coding-Alchemist-Abhijay how are we progressing on this?
>
> Hi @vatsrahul1001 ,
>
> Apologies for the delay — I was tied up with a hackathon over the past few days. I’m back now and actively working on this again. I’m consistently reviewing the CI failures and pushing fixes to address them.
>
> Thanks for your patience, and I appreciate your continued guidance on this PR.
Thanks @Coding-Alchemist-Abhijay I will review soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3691265127
Thanks for PR🙌
It seems that the tests are failing.
Could you let me know if the tests passed when you ran them locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "Coding-Alchemist-Abhijay (via GitHub)" <gi...@apache.org>.
Coding-Alchemist-Abhijay commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3693573096
> Thanks for PR🙌 It seems that the tests are failing. Could you let me know if the tests passed when you ran them locally?
Hi @choo121600 ,
I hope you’re doing well. I ran into some issues while trying to run the tests locally on my Windows machine, so I switched to GitHub Codespaces. Unfortunately, I encountered similar difficulties there as well, which is why I wasn’t able to successfully run the tests locally for this PR.
As I’m still new to open-source contributions, I’m in the process of learning the project’s setup and testing workflow. I kindly request a bit of time to debug the environment issues, fix them, and re-run the tests locally before updating the PR.
Thank you for your patience and understanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3709721109
@Coding-Alchemist-Abhijay did you get a chance to fix the review comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "Coding-Alchemist-Abhijay (via GitHub)" <gi...@apache.org>.
Coding-Alchemist-Abhijay commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3765286320
> For the comments, you may mark the ones that have already been addressed as resolved. This would help reviewers better follow the review flow ;)
Ok i will take care from next Time ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3888689930
> Following from the [conversation](https://github.com/apache/airflow/issues/59028#issuecomment-3885555584) on the E2E test meta issue. I wonder if we can cover all these conditions with unit tests instead of E2E.
I agree, let's remove pagination and sorting tests. We should create unit tests for them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(e2e): verify DAG code is displayed in Code tab [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-4177716649
This pull request has had no activity from the author for over 4 weeks. We are converting it to draft to keep the review queue manageable.
**@Coding-Alchemist-Abhijay**, please mark this PR as ready for review when you are ready to continue working on it. Thank you for your contribution!
<!-- Pull Request quality criteria -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org