[GitHub] [doris] morrySnow commented on a diff in pull request #10499: [Feature](neireids) Add support of ProjectNode in PlanTranslator

[GitBox <gi...@apache.org>]

morrySnow commented on code in PR #10499:
URL: https://github.com/apache/doris/pull/10499#discussion_r911585403


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/NereidsPlanner.java:
##########
@@ -67,11 +70,17 @@ public void plan(StatementBase queryStmt,
         physicalPlanTranslator.translatePlan(physicalPlan, planContext);
         fragments = new ArrayList<>(planContext.getPlanFragmentList());
         PlanFragment root = fragments.get(fragments.size() - 1);
+        for (PlanFragment fragment : fragments) {
+            fragment.finalize(queryStmt);
+        }
         root.setOutputExprs(queryStmt.getResultExprs());
         if (VectorizedUtil.isVectorized()) {
             root.getPlanRoot().convertToVectoriezd();
         }
         scanNodeList = planContext.getScanNodeList();
+        descTable = planContext.getDescTable();
+        Collections.reverse(fragments);
+        planContext.getDescTable().computeStatAndMemLayout();

Review Comment:
   vectorized engine do not need this



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/FindFunction.java:
##########
@@ -0,0 +1,55 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//  http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.expressions;
+
+import org.apache.doris.nereids.trees.expressions.functions.BoundFunction;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Find all function call in the given expression tree.
+ */
+public class FindFunction extends ExpressionVisitor<Void, List<BoundFunction>> {

Review Comment:
   use collect directly



##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -237,7 +238,8 @@ public Coordinator(ConnectContext context, Analyzer analyzer, Planner planner) {
         this.queryId = context.queryId();
         this.fragments = planner.getFragments();
         this.scanNodes = planner.getScanNodes();
-        this.descTable = analyzer.getDescTbl().toThrift();
+        this.descTable = planner instanceof NereidsPlanner ? planner.getDescTable().toThrift()
+                : analyzer.getDescTbl().toThrift();

Review Comment:
   both NereidsPlanner and OriginalPlanner already implement interface getDescTable, we could call getDescTable for both of them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org