[jira] [Comment Edited] (LOG4J2-760) XMLLayout's dependence on jackson-annotations should be documented

["Remko Popma (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4J2-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088875#comment-14088875 ] 

Remko Popma edited comment on LOG4J2-760 at 8/7/14 6:04 AM:
------------------------------------------------------------

Bear in mind that if users are using Maven this problem will not occur (Maven will pull in the transitive dependencies). If users can execute Maven commands they likely won't have this issue.

I see these three options (there may be others, let me know if you think of any)
# Add an explicit dependency to jackson-annotations in log4j-core/pom.xml.  
#* Pros: only one place to maintain, docs generated automatically. 
#* Cons: not strictly necessary for the build and if Jackson changes in the future we need to manually update.
# Document the dependency on the site (Layout manual pages and perhaps the FAQ page). 
#* Pros: ?.  (Perhaps this is user-friendlier?)
#* Cons: multiple places to edit, if Jackson changes in the future we still need to manually update.
# Leave it as it is (leave this issue unsolved).
#* Pros: nothing to edit now, no updates required if Jackson changes in the future.
#* Cons: Users without an automatic build system will have trouble using XML and JSON layouts.

Sounds like updating the core pom is the least of all evils...


was (Author: remkop@yahoo.com):
Bear in mind that if users are using Maven this problem will not occur (Maven will pull in the transitive dependencies). If users can execute Maven commands they likely won't have this issue.

I see these three options (there may be others, let me know if you think of any)
# Add an explicit dependency to jackson-annotations in log4j-core/pom.xml.  
#* Pros: only one place to maintain, docs generated automatically. 
#* Cons: not strictly necessary and if Jackson changes in the future we need to manually update.
# Document the dependency on the site (Layout manual pages and perhaps the FAQ page). 
#* Pros: ?. 
#* Cons: multiple places to edit, if Jackson changes in the future we still need to manually update.
# Leave it as it is.
#* Pros: nothing to edit now, no updates required if Jackson changes in the future.
#* Cons: Users without an automatic build system will have trouble using XML and JSON layouts.

Sounds like updating the core pom is the least of all evils...

> XMLLayout's dependence on jackson-annotations should be documented
> ------------------------------------------------------------------
>
>                 Key: LOG4J2-760
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-760
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Layouts
>    Affects Versions: 2.0-rc2, 2.0
>         Environment: Windows JDK 1.7.0_65
>            Reporter: Dale Furrow
>             Fix For: 2.0.2
>
>         Attachments: BasicScreenshot.jpg, screenshot - with Jacson 2.4.1.jpg, screenshot-success.jpg
>
>
> Hello--first time report please bear with me.
> Upgrading project from 2.0-rc1 to 2.0, ran into the following issue:
> Layout<? extends Serializable> xmlLayout =  xmlLayout.createDefaultLayout();
> produces the following error:
> Exception in thread "main" java.lang.NoClassDefFoundError: com/fasterxml/jackson/core/JsonProcessingException
> I've included the API and Core JAR's to the project path, as previously.  For reference, I'm comparing this line with the following line that runs correctly in rc1:
> Layout<? extends Serializable> fileXMLLayout = XMLLayout.createLayout("true", "true", null, null, null, null);



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org