You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/01/29 03:40:01 UTC

[GitHub] [drill] paul-rogers commented on a change in pull request #2433: DRILL-8111: Remove lombok usage

paul-rogers commented on a change in pull request #2433:
URL: https://github.com/apache/drill/pull/2433#discussion_r794992560



##########
File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpPaginatorConfig.java
##########
@@ -69,6 +60,85 @@
   @JsonProperty
   private final String method;
 
+  public HttpPaginatorConfig(HttpPaginatorConfigBuilder builder) {
+    this.limitParam = builder.limitParam;
+    this.offsetParam = builder.offsetParam;
+    this.pageParam = builder.pageParam;
+    this.pageSizeParam = builder.pageSizeParam;
+    this.pageSize = builder.pageSize;
+    this.maxRecords = builder.maxRecords;
+    this.method = builder.method;
+  }
+
+  public static HttpPaginatorConfigBuilder builder() {
+    return new HttpPaginatorConfigBuilder();
+  }
+
+  public String limitParam() {
+    return this.limitParam;
+  }
+
+  public String offsetParam() {
+    return this.offsetParam;
+  }
+
+  public String pageParam() {
+    return this.pageParam;
+  }
+
+  public String pageSizeParam() {
+    return this.pageSizeParam;
+  }
+
+  public int pageSize() {
+    return this.pageSize;
+  }
+
+  public int maxRecords() {
+    return this.maxRecords;
+  }
+
+  public String method() {
+    return this.method;
+  }
+
+  @Override
+  public boolean equals(Object o) {
+    if (this == o) {
+      return true;
+    }
+    if (o == null || getClass() != o.getClass()) {
+      return false;
+    }
+    HttpPaginatorConfig that = (HttpPaginatorConfig) o;
+    return pageSize == that.pageSize
+      && maxRecords == that.maxRecords
+      && Objects.equals(limitParam, that.limitParam)
+      && Objects.equals(offsetParam, that.offsetParam)
+      && Objects.equals(pageParam, that.pageParam)
+      && Objects.equals(pageSizeParam, that.pageSizeParam)
+      && Objects.equals(method, that.method);
+  }
+
+  @Override
+  public int hashCode() {
+    return Objects.hash(limitParam, offsetParam, pageParam, pageSizeParam,
+      pageSize, maxRecords, method);
+  }
+
+  @Override
+  public String toString() {

Review comment:
       There is a `PlanStringBuilder` that can help with this tedium.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org