[jira] [Commented] (YARN-4878) Expose scheduling policy and max running apps over JMX for Yarn queues

["Ray Chiang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-4878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289697#comment-15289697 ] 

Ray Chiang commented on YARN-4878:
----------------------------------

Some minor nitpicks:

- Change the metric description from "Maximum applications number" to "Maximum number of applications"
- For readability, I'd recommend changing this style:

{noformat}
  public synchronized
  static FSQueueMetrics forQueue(String queueName, Queue parent,
      boolean enableUserMetrics, Configuration conf) {
{noformat}

   to this:

{noformat}
  public static synchronized FSQueueMetrics forQueue(String queueName,
      Queue parent, boolean enableUserMetrics, Configuration conf) {
{noformat}

  In general, it's best to have the code readable, not best diff compatibility.


> Expose scheduling policy and max running apps over JMX for Yarn queues
> ----------------------------------------------------------------------
>
>                 Key: YARN-4878
>                 URL: https://issues.apache.org/jira/browse/YARN-4878
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: yarn
>    Affects Versions: 2.9.0
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>         Attachments: YARN-4878.001.patch, YARN-4878.002.patch
>
>
> There are two things that are not currently visible over JMX: the current scheduling policy for a queue, and the number of max running apps. It would be great if these could be exposed over JMX as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org