You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2025/02/27 09:00:55 UTC
[PR] fix: Use chrono's quarter() to avoid conflict (#7198) [arrow-rs]
Xuanwo opened a new pull request, #7210:
URL: https://github.com/apache/arrow-rs/pull/7210
# Which issue does this PR close?
Part of https://github.com/apache/arrow-rs/issues/7209
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please call them out.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono < 0.4.40 to avoid breaking [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #7210:
URL: https://github.com/apache/arrow-rs/pull/7210#discussion_r1973307340
##########
Cargo.toml:
##########
@@ -93,4 +93,4 @@ arrow-select = { version = "54.2.0", path = "./arrow-select" }
arrow-string = { version = "54.2.0", path = "./arrow-string" }
parquet = { version = "54.2.0", path = "./parquet", default-features = false }
-chrono = { version = "0.4.34", default-features = false, features = ["clock"] }
+chrono = { version = "< 0.4.40", default-features = false, features = ["clock"] }
Review Comment:
```suggestion
chrono = { version = "0.4.34, < 0.4.40", default-features = false, features = ["clock"] }
```
Or whatever the syntax is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono < 0.4.40 to avoid breaking [arrow-rs]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #7210:
URL: https://github.com/apache/arrow-rs/pull/7210#issuecomment-2687531592
cc @tustvold, please let me know if this what you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono's quarter() to avoid conflict (cherry-pick) [arrow-rs]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #7210:
URL: https://github.com/apache/arrow-rs/pull/7210#issuecomment-2687525406
> In which case I think we should either change the constrain in this PR to be `< 0.4.40` or use the disambiguification syntax. Otherwise people who have fixed their builds will have them break again.
Oh, I see. You mean we enforce users to use `<0.4.40` in `54.2.1` and `>=0.4.40` starting from `55.3.0` (the next minor release). The good thing is that users who have already fixed this issue by pinning `chrono` won't be affected again. That makes sense. Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono's quarter() to avoid conflict (cherry-pick) [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #7210:
URL: https://github.com/apache/arrow-rs/pull/7210#issuecomment-2687361854
If people may have pinned an older version of chrono, will cargo pick this patch release of arrow and error, or is it smart enough to sort things out?
Wonder if we should use the disambiguification syntax for the backport instead...
_Thank you for doing this, I've already spent more time on this chrono nonsense than I hoped to, and have a depressingly long backlog of other work..._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono < 0.4.40 to avoid breaking [arrow-rs]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #7210:
URL: https://github.com/apache/arrow-rs/pull/7210#discussion_r1973310112
##########
Cargo.toml:
##########
@@ -93,4 +93,4 @@ arrow-select = { version = "54.2.0", path = "./arrow-select" }
arrow-string = { version = "54.2.0", path = "./arrow-string" }
parquet = { version = "54.2.0", path = "./parquet", default-features = false }
-chrono = { version = "0.4.34", default-features = false, features = ["clock"] }
+chrono = { version = "< 0.4.40", default-features = false, features = ["clock"] }
Review Comment:
Oh, you are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono's quarter() to avoid conflict (cherry-pick) [arrow-rs]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #7210:
URL: https://github.com/apache/arrow-rs/pull/7210#issuecomment-2687385998
> If people may have pinned an older version of chrono, will cargo pick this patch release of arrow and error, or is it smart enough to sort things out?
cargo will refuse to build if the user tries to use an old version of `chrono` since we enforce the user to use `>= 0.4.40`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono < 0.4.40 to avoid breaking [arrow-rs]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #7210:
URL: https://github.com/apache/arrow-rs/pull/7210#discussion_r1973308641
##########
Cargo.toml:
##########
@@ -93,4 +93,4 @@ arrow-select = { version = "54.2.0", path = "./arrow-select" }
arrow-string = { version = "54.2.0", path = "./arrow-string" }
parquet = { version = "54.2.0", path = "./parquet", default-features = false }
-chrono = { version = "0.4.34", default-features = false, features = ["clock"] }
+chrono = { version = "< 0.4.40", default-features = false, features = ["clock"] }
Review Comment:
`< 0.4.40` should them all, I guess.
##########
Cargo.toml:
##########
@@ -93,4 +93,4 @@ arrow-select = { version = "54.2.0", path = "./arrow-select" }
arrow-string = { version = "54.2.0", path = "./arrow-string" }
parquet = { version = "54.2.0", path = "./parquet", default-features = false }
-chrono = { version = "0.4.34", default-features = false, features = ["clock"] }
+chrono = { version = "< 0.4.40", default-features = false, features = ["clock"] }
Review Comment:
`< 0.4.40` should conver them all, I guess.
##########
Cargo.toml:
##########
@@ -93,4 +93,4 @@ arrow-select = { version = "54.2.0", path = "./arrow-select" }
arrow-string = { version = "54.2.0", path = "./arrow-string" }
parquet = { version = "54.2.0", path = "./parquet", default-features = false }
-chrono = { version = "0.4.34", default-features = false, features = ["clock"] }
+chrono = { version = "< 0.4.40", default-features = false, features = ["clock"] }
Review Comment:
`< 0.4.40` should cover them all, I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono >= 0.4.34, < 0.4.40 to avoid breaking [arrow-rs]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #7210:
URL: https://github.com/apache/arrow-rs/pull/7210#discussion_r1973312097
##########
Cargo.toml:
##########
@@ -93,4 +93,4 @@ arrow-select = { version = "54.2.0", path = "./arrow-select" }
arrow-string = { version = "54.2.0", path = "./arrow-string" }
parquet = { version = "54.2.0", path = "./parquet", default-features = false }
-chrono = { version = "0.4.34", default-features = false, features = ["clock"] }
+chrono = { version = "< 0.4.40", default-features = false, features = ["clock"] }
Review Comment:
Fixed in https://github.com/apache/arrow-rs/pull/7210/commits/96674289a7c8ca8508dd67aafb17334f97b47d84
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono's quarter() to avoid conflict (cherry-pick) [arrow-rs]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #7210:
URL: https://github.com/apache/arrow-rs/pull/7210#issuecomment-2687392272
> Thank you for doing this, I've already spent more time on this chrono nonsense than I hoped to, and have a depressingly long backlog of other work...
:heart:, happy to provide help.
I noticed your discussion with chrono, and in my opinion, the best approach is to use an API like `arrow_xxx` to prevent this from happening again. Maybe I should start a dicussion for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono < 0.4.40 to avoid breaking [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #7210:
URL: https://github.com/apache/arrow-rs/pull/7210#discussion_r1973307340
##########
Cargo.toml:
##########
@@ -93,4 +93,4 @@ arrow-select = { version = "54.2.0", path = "./arrow-select" }
arrow-string = { version = "54.2.0", path = "./arrow-string" }
parquet = { version = "54.2.0", path = "./parquet", default-features = false }
-chrono = { version = "0.4.34", default-features = false, features = ["clock"] }
+chrono = { version = "< 0.4.40", default-features = false, features = ["clock"] }
Review Comment:
```suggestion
chrono = { version = "0.4.34, < 0.4.40", default-features = false, features = ["clock"] }
```
Or whatever the syntax is, we want >=0.4.34 and <0.4.40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono < 0.4.40 to avoid breaking [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #7210:
URL: https://github.com/apache/arrow-rs/pull/7210#discussion_r1973309325
##########
Cargo.toml:
##########
@@ -93,4 +93,4 @@ arrow-select = { version = "54.2.0", path = "./arrow-select" }
arrow-string = { version = "54.2.0", path = "./arrow-string" }
parquet = { version = "54.2.0", path = "./parquet", default-features = false }
-chrono = { version = "0.4.34", default-features = false, features = ["clock"] }
+chrono = { version = "< 0.4.40", default-features = false, features = ["clock"] }
Review Comment:
I think that would permit `0.4.32` which would then fail to build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono's quarter() to avoid conflict (#7198) [arrow-rs]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #7210:
URL: https://github.com/apache/arrow-rs/pull/7210#issuecomment-2687317471
cc @alamb and @tustvold for a look, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono's quarter() to avoid conflict (cherry-pick) [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #7210:
URL: https://github.com/apache/arrow-rs/pull/7210#issuecomment-2687406409
> cargo will refuse to build if the user tries to use an old version of chrono since we enforce the user to use >= 0.4.40.
In which case I think we should either change the constrain in this PR to be `< 0.4.40` or use the disambiguification syntax. Otherwise people who have fixed their builds will have them break again.
> Maybe I should start a dicussion for this?
Having a discussion is probably good just to surface this, although ultimately if chrono takes the policy it is, we effectively need to use disambiguification syntax for all traits where chrono traits are in scope - as they theoretically could conflict with any other trait in context. In this case the collision was with an extension trait, but theoretically the collisions are possible with anything... It may be the only pragmatic approach is hope they don't break stuff, what the chrono maintainer effectively suggested, which leaves a bad taste in my mouth but may be the only option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use chrono >= 0.4.34, < 0.4.40 to avoid breaking [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #7210:
URL: https://github.com/apache/arrow-rs/pull/7210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org