[GitHub] [superset] villebro commented on a change in pull request #15012: fix(native-filters): avoid double load on select initialization

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #15012:
URL: https://github.com/apache/superset/pull/15012#discussion_r646452744



##########
File path: superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -109,6 +109,7 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
   } = formData;
   const groupby = ensureIsArray<string>(formData.groupby);
   const [col] = groupby;
+  const [initialColtypeMap] = useState(coltypeMap);

Review comment:
       I think we should ultimately make the chart component check if a call to `buildQuery` actually returns a changed query. This way we could avoid retriggering queries when `ownState` changes but the actual `QueryObject`s or `QueryContext` doesn't change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org