You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by Daniel Wilson <wi...@gmail.com> on 2009/05/01 15:10:42 UTC
Re: svn commit: r770643 - /incubator/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDColorSpaceFactory.java
Sorry about that, Andreas. I guess I'm not sufficiently familiar with
TortoiseSVN.
When I've made a change in a file, what SVN operation do I need to do prior
to committing to see any other changes made?
And can a representative document be added to the tests so that I can catch
it if I (or someone else) should break it again?
Thanks.
Daniel
On Fri, May 1, 2009 at 7:39 AM, <le...@apache.org> wrote:
> Author: lehmi
> Date: Fri May 1 11:39:34 2009
> New Revision: 770643
>
> URL: http://svn.apache.org/viewvc?rev=770643&view=rev
> Log:
> PDFBOX-264: re-checkin of my changes from version 761608. They got lost
> with version 762859.
>
> Modified:
>
> incubator/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDColorSpaceFactory.java
>
> Modified:
> incubator/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDColorSpaceFactory.java
> URL:
> http://svn.apache.org/viewvc/incubator/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDColorSpaceFactory.java?rev=770643&r1=770642&r2=770643&view=diff
>
> ==============================================================================
> ---
> incubator/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDColorSpaceFactory.java
> (original)
> +++
> incubator/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDColorSpaceFactory.java
> Fri May 1 11:39:34 2009
> @@ -69,6 +69,10 @@
> {
> retval = new PDCalGray( array );
> }
> + else if( type.getName().equals( PDDeviceRGB.NAME ) )
> + {
> + retval = PDDeviceRGB.INSTANCE;
> + }
> else if( type.getName().equals( PDCalRGB.NAME ) )
> {
> retval = new PDCalRGB( array );
>
>
>
Re: svn commit: r770643 - /incubator/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDColorSpaceFactory.java
Posted by Andreas Lehmkühler <an...@lehmi.de>.
Daniel Wilson schrieb:
> Sorry about that, Andreas.
No problem at all. That happens.
> I guess I'm not sufficiently familiar with
> TortoiseSVN.
>
> When I've made a change in a file, what SVN operation do I need to do prior
> to committing to see any other changes made?
Whenever I want to checkin some changes I run a diff/compare on my local
copy and the latest version from the repository, so that I'm able to see
if there are any changes I don't have in mind because of a newer version
in svn. If there is such a conflict an update on that file should merge
all changes from svn to my local copy automatically. If your changes are
in conflict with the changes made in the svn it might necessary to do
that update by hand.
> And can a representative document be added to the tests so that I can catch
> it if I (or someone else) should break it again?
There is such a document attached to PDFBOX-264.
HTH
Andreas Lehmkühler
>
> On Fri, May 1, 2009 at 7:39 AM, <le...@apache.org> wrote:
>
>> Author: lehmi
>> Date: Fri May 1 11:39:34 2009
>> New Revision: 770643
>>
>> URL: http://svn.apache.org/viewvc?rev=770643&view=rev
>> Log:
>> PDFBOX-264: re-checkin of my changes from version 761608. They got lost
>> with version 762859.
>>
>> Modified:
>>
>> incubator/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDColorSpaceFactory.java
>>
>> Modified:
>> incubator/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDColorSpaceFactory.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDColorSpaceFactory.java?rev=770643&r1=770642&r2=770643&view=diff
>>
>> ==============================================================================
>> ---
>> incubator/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDColorSpaceFactory.java
>> (original)
>> +++
>> incubator/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDColorSpaceFactory.java
>> Fri May 1 11:39:34 2009
>> @@ -69,6 +69,10 @@
>> {
>> retval = new PDCalGray( array );
>> }
>> + else if( type.getName().equals( PDDeviceRGB.NAME ) )
>> + {
>> + retval = PDDeviceRGB.INSTANCE;
>> + }
>> else if( type.getName().equals( PDCalRGB.NAME ) )
>> {
>> retval = new PDCalRGB( array );
>>
>>
>>
>