[GitHub] [doris] englefly commented on a diff in pull request #11209: [feature] (Nereids) support limit clause

[GitBox <gi...@apache.org>]

englefly commented on code in PR #11209:
URL: https://github.com/apache/doris/pull/11209#discussion_r930831997


##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -119,6 +119,12 @@ sortItem
     :  expression ordering = (ASC | DESC)?
     ;
 
+limitClause
+    : (LIMIT INTEGER_VALUE)?
+    | (LIMIT INTEGER_VALUE OFFSET INTEGER_VALUE)?
+    | (LIMIT INTEGER_VALUE COMMA INTEGER_VALUE)?

Review Comment:
   `select * from t order by a limit 100, 3` 
   is equivalent to 
   `select * from t order by a limit 3 offset 100`
   we should follow our `cup` definition.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org