You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:07:58 UTC

Re: Review Request 48453: Track UPIDs based on executor id in scheduler driver.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48453/#review167326
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews.

- Joris Van Remoortere


On June 9, 2016, 1:08 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48453/
> -----------------------------------------------------------
> 
> (Updated June 9, 2016, 1:08 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5143
>     https://issues.apache.org/jira/browse/MESOS-5143
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since UPIDs are tracked in the scheduler driver to be able to directly
> send FrameworkMessage to executor, we now track UPIDs for an executor
> running on an agent (instead for a slave). We track this mapping only
> for the life of the executor (instead of the life of the agent). This
> enables us to avoid sending lost slave message to all frameworks
> (instead of relevant frameworks only).
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp 9f561d73a2e591afdc3ba4adb35a11763dced402 
> 
> 
> Diff: https://reviews.apache.org/r/48453/diff/1/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>