You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "currenjin (via GitHub)" <gi...@apache.org> on 2026/04/09 23:51:44 UTC
[PR] Add unit tests for JDBCMetricsQueryDAO, JDBCServiceLabelQueryDAO, and JDBCSpanAttachedEventQueryDAO [skywalking]
currenjin opened a new pull request, #13809:
URL: https://github.com/apache/skywalking/pull/13809
## What's this PR about?
Adds unit tests for 3 more JDBC query DAOs that use inline SQL (no protected `buildSQL` method). These use Mockito SQL capture to verify the generated queries.
With the previous rounds (#13800, #13802, #13808), DAO test coverage goes from 18/39 (46%) to 21/39 (54%).
## Tests
| DAO | Approach | Tests |
|-----|----------|-------|
| JDBCMetricsQueryDAO | protected `buildMetricsValueSql()` + Mockito capture for `readLabeledMetricsValuesWithoutEntity()` | select with aggregation op, TABLE_COLUMN + TIME_BUCKET range + limit |
| JDBCServiceLabelQueryDAO | Mockito SQL capture | TABLE_COLUMN + SERVICE_ID filter, select LABEL column |
| JDBCSpanAttachedEventQueryDAO | Mockito SQL capture for both ZK and SW methods | TABLE_COLUMN + trace ID IN clause, order by start_time_second/nanos |
All 8 new test cases pass locally.
## Which issue does this PR relate to?
N/A - test coverage improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add unit tests for 8 more JDBC query DAOs (inline SQL) [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #13809:
URL: https://github.com/apache/skywalking/pull/13809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add unit tests for 8 more JDBC query DAOs (inline SQL) [skywalking]
Posted by "wm-currenjin (via GitHub)" <gi...@apache.org>.
wm-currenjin commented on PR #13809:
URL: https://github.com/apache/skywalking/pull/13809#issuecomment-4221913957
The `OTLP Virtual GenAI` and `Zipkin Virtual GenAI` failures are pre-existing on the master branch (run [24206557119](https://github.com/apache/skywalking/actions/runs/24206557119)) and are unrelated to this PR. This PR only adds unit tests in the JDBC storage plugin and does not touch any GenAI or OTLP code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add unit tests for 8 more JDBC query DAOs (inline SQL) [skywalking]
Posted by "currenjin (via GitHub)" <gi...@apache.org>.
currenjin commented on PR #13809:
URL: https://github.com/apache/skywalking/pull/13809#issuecomment-4222008220
The `OTLP Virtual GenAI` and `Zipkin Virtual GenAI` failures are pre-existing on the master branch (run [24206557119](https://github.com/apache/skywalking/actions/runs/24206557119)) and are unrelated to this PR. This PR only adds unit tests in the JDBC storage plugin and does not touch any GenAI or OTLP code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add unit tests for 8 more JDBC query DAOs (inline SQL) [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #13809:
URL: https://github.com/apache/skywalking/pull/13809#issuecomment-4221778331
GenAI e2e seems to have some issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add unit tests for 8 more JDBC query DAOs (inline SQL) [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #13809:
URL: https://github.com/apache/skywalking/pull/13809#issuecomment-4222105292
I knew. I am working on checking what caused that. It seems the cases don't lock the dependency versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org