You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "acassis (via GitHub)" <gi...@apache.org> on 2023/10/17 15:13:37 UTC
[PR] esp32: Add wifishare board config and documentation [nuttx]
acassis opened a new pull request, #10961:
URL: https://github.com/apache/nuttx/pull/10961
## Summary
esp32: Add wifishare board config and documentation
## Impact
Users will be able to use ESP32 board as Access Point and Base Station at same time and share Internet connection!
## Testing
ESP32-Devkit
Thanks Zhe Weng for helping!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] esp32: Add wifishare board config and documentation [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10961:
URL: https://github.com/apache/nuttx/pull/10961#discussion_r1364152007
##########
net/route/net_del_ramroute.c:
##########
@@ -91,7 +91,8 @@ static int net_match_ipv4(FAR struct net_route_ipv4_s *route, FAR void *arg)
net_ipv4_dumproute("Comparing", route);
ninfo("With:\n");
ninfo(" target=%08" PRIx32 " netmask=%08" PRIx32 "\n",
- HTONL(match->target), HTONL(match->netmask));
+ (unsigned long int)HTONL(match->target),
Review Comment:
it's better to add the cast at https://github.com/apache/nuttx/blob/master/include/netinet/in.h#L233-L241 to ensure the type in these macros same as:
https://github.com/apache/nuttx/blob/master/include/netinet/in.h#L377-L382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] esp32: Add wifishare board config and documentation [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #10961:
URL: https://github.com/apache/nuttx/pull/10961#issuecomment-1767322281
@xiaoxiang781216 the macro HTONL(match->target) is returning different types of integer depending on architecture and compiler. What should be the right fix here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] esp32: Add wifishare board config and documentation [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10961:
URL: https://github.com/apache/nuttx/pull/10961#discussion_r1364255949
##########
net/route/net_del_ramroute.c:
##########
@@ -91,7 +91,8 @@ static int net_match_ipv4(FAR struct net_route_ipv4_s *route, FAR void *arg)
net_ipv4_dumproute("Comparing", route);
ninfo("With:\n");
ninfo(" target=%08" PRIx32 " netmask=%08" PRIx32 "\n",
- HTONL(match->target), HTONL(match->netmask));
+ (unsigned long int)HTONL(match->target),
Review Comment:
@acassis https://github.com/apache/nuttx/pull/10974 may fix your problem, please try it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] esp32: Add wifishare board config and documentation [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #10961:
URL: https://github.com/apache/nuttx/pull/10961#issuecomment-1769091174
> Thank you @xiaoxiang781216 I applied temporarily your patch here just to confirm it will fix the issue. If the CI pass I remove this commit, apply your PR and rebase my PR with it.
let's reuse your pr to simplify the process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] esp32: Add wifishare board config and documentation [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10961:
URL: https://github.com/apache/nuttx/pull/10961#discussion_r1363325887
##########
net/route/net_del_ramroute.c:
##########
@@ -91,7 +91,8 @@ static int net_match_ipv4(FAR struct net_route_ipv4_s *route, FAR void *arg)
net_ipv4_dumproute("Comparing", route);
ninfo("With:\n");
ninfo(" target=%08" PRIx32 " netmask=%08" PRIx32 "\n",
- HTONL(match->target), HTONL(match->netmask));
+ (unsigned long int)HTONL(match->target),
Review Comment:
why need change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] esp32: Add wifishare board config and documentation [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #10961:
URL: https://github.com/apache/nuttx/pull/10961#discussion_r1364016806
##########
net/route/net_del_ramroute.c:
##########
@@ -91,7 +91,8 @@ static int net_match_ipv4(FAR struct net_route_ipv4_s *route, FAR void *arg)
net_ipv4_dumproute("Comparing", route);
ninfo("With:\n");
ninfo(" target=%08" PRIx32 " netmask=%08" PRIx32 "\n",
- HTONL(match->target), HTONL(match->netmask));
+ (unsigned long int)HTONL(match->target),
Review Comment:
Initially because the Xtensa CI is complain: "error: format specifies type 'unsigned int' but the argument has type 'unsigned long long'", then I cast to "(unsigned int)", but then ARM CI started failing because it was expecting "unsigned long int".
As you can see, there is not a cast that will work for all. This is why I asked if you know how to fix it!?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] esp32: Add wifishare board config and documentation [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #10961:
URL: https://github.com/apache/nuttx/pull/10961#issuecomment-1769062014
Thank you @xiaoxiang781216 I applied temporarily your patch here just to confirm it will fix the issue. If the CI pass I remove this commit, apply your PR and rebase my PR with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] esp32: Add wifishare board config and documentation [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #10961:
URL: https://github.com/apache/nuttx/pull/10961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org