You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "kanha-gupta (via GitHub)" <gi...@apache.org> on 2023/05/24 18:39:39 UTC
[GitHub] [shardingsphere] kanha-gupta opened a new pull request, #25876: Support for AMPERSAND,CARET AND DIV
kanha-gupta opened a new pull request, #25876:
URL: https://github.com/apache/shardingsphere/pull/25876
Ref #24200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kanha-gupta closed pull request #25876: Support for AMPERSAND,CARET AND DIV
Posted by "kanha-gupta (via GitHub)" <gi...@apache.org>.
kanha-gupta closed pull request #25876: Support for AMPERSAND,CARET AND DIV
URL: https://github.com/apache/shardingsphere/pull/25876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #25876: Support for AMPERSAND,CARET AND DIV
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on code in PR #25876:
URL: https://github.com/apache/shardingsphere/pull/25876#discussion_r1204906523
##########
kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/converter/segment/expression/impl/BinaryOperationExpressionConverter.java:
##########
@@ -107,6 +109,15 @@ private SqlOperator convertOperator(final BinaryOperationExpression segment) {
operator = "IS NOT FALSE";
}
}
+ if ("&".equalsIgnoreCase(operator)) {
Review Comment:
Hi @kanha-gupta, can you show sql node toString result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kanha-gupta commented on pull request #25876: Support for AMPERSAND,CARET AND DIV
Posted by "kanha-gupta (via GitHub)" <gi...@apache.org>.
kanha-gupta commented on PR #25876:
URL: https://github.com/apache/shardingsphere/pull/25876#issuecomment-1561761185
@strongduanmu Since calcite do not support these operators natively, I have added support for it through method call.
Please review :)
(Images are attached in the above message thread)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #25876: Support for AMPERSAND,CARET AND DIV
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #25876:
URL: https://github.com/apache/shardingsphere/pull/25876#issuecomment-1562424186
Hi @kanha-gupta, you can refer pr https://github.com/apache/shardingsphere/pull/25882 to add sql case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org