[GitHub] [incubator-nuttx] jarivanewijk commented on a change in pull request #4541: S32K1XX EVB boards cleanup & update

[GitBox <gi...@apache.org>]

jarivanewijk commented on a change in pull request #4541:
URL: https://github.com/apache/incubator-nuttx/pull/4541#discussion_r708383521



##########
File path: boards/arm/s32k1xx/s32k146evb/src/s32k1xx_spi.c
##########
@@ -146,13 +186,15 @@ uint8_t s32k1xx_lpspi0status(FAR struct spi_dev_s *dev, uint32_t devid)
 {
   return 0;
 }
-#endif
+#endif /* CONFIG_S32K1XX_LPSPI0 */
+
+/* LPSPI1 *******************************************************************/
 
 #ifdef CONFIG_S32K1XX_LPSPI1
-void s32k1xx_lpspi1select(FAR struct spi_dev_s *dev,
-                        uint32_t devid, bool selected)
+void s32k1xx_lpspi1select(FAR struct spi_dev_s *dev, uint32_t devid,
+                          bool selected)
 {
-  spiinfo("devid: %d CS: %s\n", (int)devid,
+  spiinfo("devid: %d, CS: %s\n", (int) devid,

Review comment:
       Thanks for reviewing, @davids5! I am not sure though what change you are requesting. Looks like many boards use the exact same code? Do you have any example of what this should look like instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org