You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/22 19:47:47 UTC

[GitHub] [beam] shhivam opened a new pull request, #22417: Add an example for `Distinct` PTransform

shhivam opened a new pull request, #22417:
URL: https://github.com/apache/beam/pull/22417

   I noticed that there was no example for `Distinct` Java PTransform in the docs.
   
   This PR changes that -- We add an example for `Distinct` Java PTransform in the docs.
   
   Addresses some part of [BEAM-7703](https://issues.apache.org/jira/browse/BEAM-7703).
   
   About choosing **Reviewers:** Not sure who to assign as a reviewer because I don't know who works on beam
   
   
   ------------------------
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [x] Update `CHANGES.md` with noteworthy changes.
    - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #22417: Add an example for `Distinct` PTransform

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22417:
URL: https://github.com/apache/beam/pull/22417#issuecomment-1203018820

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] pabloem commented on pull request #22417: Add an example for `Distinct` PTransform

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22417:
URL: https://github.com/apache/beam/pull/22417#issuecomment-1208631965

   LGTM thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] pabloem commented on pull request #22417: Add an example for `Distinct` PTransform

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22417:
URL: https://github.com/apache/beam/pull/22417#issuecomment-1208606835

   hi thanks for the contribution! I'll rerun the tests so I can see the staged outcome


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] shhivam commented on pull request #22417: Add an example for `Distinct` PTransform

Posted by GitBox <gi...@apache.org>.
shhivam commented on PR #22417:
URL: https://github.com/apache/beam/pull/22417#issuecomment-1203017674

   R: @pabloem @jrmccluskey 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] pabloem closed pull request #22417: Add an example for `Distinct` PTransform

Posted by GitBox <gi...@apache.org>.
pabloem closed pull request #22417: Add an example for `Distinct` PTransform
URL: https://github.com/apache/beam/pull/22417


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] pabloem merged pull request #22417: Add an example for `Distinct` PTransform

Posted by GitBox <gi...@apache.org>.
pabloem merged PR #22417:
URL: https://github.com/apache/beam/pull/22417


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] shhivam commented on pull request #22417: Add an example for `Distinct` PTransform

Posted by GitBox <gi...@apache.org>.
shhivam commented on PR #22417:
URL: https://github.com/apache/beam/pull/22417#issuecomment-1209388219

   Thanks @pabloem !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org