[jira] [Commented] (ROCKETMQ-3) Clean up the unit test of rocketmq

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15772186#comment-15772186 ] 

ASF GitHub Bot commented on ROCKETMQ-3:
---------------------------------------

GitHub user dongeforever opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/7

    ROCKETMQ-3 Clean up and perfect the unit test of rocketmq-broker

    Clean up and perfect the unit test of rocketmq-broker.
    Add BrokerTestHarness as a base class to create temporary BrokerController.
    Flush test has three steps:
    1 persist to the disk
    2 clear the in-memory values
    3 load from the disk.
    Used for both testFlushConsumerOffset and testFlushTopicConfig

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongeforever/incubator-rocketmq master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7
    
----
commit 4a35f9575100ca04b379f7903f7134a406c3cd01
Author: zhendongliu.lzd <zh...@alibaba-inc.com>
Date:   2016-12-23T06:49:29Z

    ROCKETMQ-3 Clean up and perfect the unit test of rocketmq-broker

commit b82d36f977dbfa6d966efc3a33d05e50a49c3b7c
Author: zhendongliu.lzd <zh...@alibaba-inc.com>
Date:   2016-12-23T07:14:15Z

    Modify configs in BrokerTestHarness to avoid conflict

----


> Clean up the unit test of rocketmq
> ----------------------------------
>
>                 Key: ROCKETMQ-3
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-3
>             Project: Apache RocketMQ
>          Issue Type: Task
>            Reporter: Willem Jiang
>
> There are lots of System.out.println and the try...catch exception code in the test of rocketmq-store module. It's better to avoid the usage of System.out.println and just through out the exception to fail the test. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)