You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "hemantk-12 (via GitHub)" <gi...@apache.org> on 2024/01/23 04:15:50 UTC
[PR] HDDS-8005. Fixed intermittent failure in TestOmSnapshot.testSnapDiffWithMultipleSSTs [ozone]
hemantk-12 opened a new pull request, #6071:
URL: https://github.com/apache/ozone/pull/6071
## What changes were proposed in this pull request?
`TestOmSnapshot.testSnapDiffWithMultipleSSTs` was failing all the time because snapshot diff is an async API and when a job is submitted for the first time, it always returns empty diff list with IN_PROGRESS status. User is supposed to make second call to fetch the results, once job is DONE. TestOmSnapshot.testSnapDiffWithMultipleSSTs was only making one call which only submits the request and returned empty diff response as mentioned above.
This change is to call snap diff after job to DONE to fetch complete diff report.
## What is the link to the Apache JIRA
HDDS-8005
## How was this patch tested?
Ran the test locally and on fork: https://github.com/hemantk-12/ozone/actions/runs/7620429542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-8005. Fixed intermittent failure in TestOmSnapshot.testSnapDiffWithMultipleSSTs [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #6071:
URL: https://github.com/apache/ozone/pull/6071#discussion_r1462940774
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOmSnapshot.java:
##########
@@ -1800,29 +1797,27 @@ public void testSnapDiffWithMultipleSSTs()
String keyPrefix = "key-";
// add file to bucket1 and take snapshot
createFileKeyWithPrefix(bucket1, keyPrefix);
+ int keyTableSize = getKeyTableSstFiles().size();
Review Comment:
I think keyTableSize will always be 0. Why is this added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-8005. Fixed intermittent failure in TestOmSnapshot.testSnapDiffWithMultipleSSTs [ozone]
Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 merged PR #6071:
URL: https://github.com/apache/ozone/pull/6071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-8005. Fixed intermittent failure in TestOmSnapshot.testSnapDiffWithMultipleSSTs [ozone]
Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 commented on PR #6071:
URL: https://github.com/apache/ozone/pull/6071#issuecomment-1906794609
Initially, I didn't run the `flaky-test-check` because this test was marked `Unhealthy` not `Flaky` which means it failed all the times.
Just to be sure as suggested above, I ran it for 5x10 for one of the TestOmSnapshot's implementation: https://github.com/hemantk-12/ozone/actions/runs/7630045775 and it passed all the times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-8005. Fixed intermittent failure in TestOmSnapshot.testSnapDiffWithMultipleSSTs [ozone]
Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 commented on PR #6071:
URL: https://github.com/apache/ozone/pull/6071#issuecomment-1906799203
Thanks @sadanand48 and @aswinshakil for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-8005. Fixed intermittent failure in TestOmSnapshot.testSnapDiffWithMultipleSSTs [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #6071:
URL: https://github.com/apache/ozone/pull/6071#discussion_r1462940774
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOmSnapshot.java:
##########
@@ -1800,29 +1797,27 @@ public void testSnapDiffWithMultipleSSTs()
String keyPrefix = "key-";
// add file to bucket1 and take snapshot
createFileKeyWithPrefix(bucket1, keyPrefix);
+ int keyTableSize = getKeyTableSstFiles().size();
Review Comment:
I think keyTableSize will always be 0. Why is this added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-8005. Fixed intermittent failure in TestOmSnapshot.testSnapDiffWithMultipleSSTs [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on PR #6071:
URL: https://github.com/apache/ozone/pull/6071#issuecomment-1905604297
Thanks @hemantk-12 , overall change looks good , left a minor comment. Could you also please run the flaky test workflow for this test a few times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org