You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "Mortom123 (via GitHub)" <gi...@apache.org> on 2024/01/23 19:42:57 UTC
[PR] expose admin port of pulsar manager in service [pulsar-helm-chart]
Mortom123 opened a new pull request, #440:
URL: https://github.com/apache/pulsar-helm-chart/pull/440
See https://github.com/apache/pulsar-helm-chart/pull/438 / https://github.com/apache/pulsar-helm-chart/pull/438#issuecomment-1903889439 2.PR
### Motivation
exposing Admin Port of Manager is needed in the future
### Modifications
expose Admin Port of Manager
### Verifying this change
- [x] Make sure that the change passes the CI checks. See https://github.com/Mortom123/pulsar-helm-chart/actions/runs/7629866629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] expose admin port of pulsar manager in service [pulsar-helm-chart]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #440:
URL: https://github.com/apache/pulsar-helm-chart/pull/440#issuecomment-1909602387
> @lhotari Mhh. You might be right. However I think the admij port gets deactivated / does not listen anymore once the account for the manager is created. But we could also make a second Node Port service I guess?
Yes I think it's better to reduce to possible exposure. One fact is that the Pulsar Helm Chart isn't following a "secure-by-default" principle currently. Anyhow we should attempt to improve the situation. I created #444 to cover other services, but I think that this admin port case could be handled outside of that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] expose admin port of pulsar manager in service [pulsar-helm-chart]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #440:
URL: https://github.com/apache/pulsar-helm-chart/pull/440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] expose admin port of pulsar manager in service [pulsar-helm-chart]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #440:
URL: https://github.com/apache/pulsar-helm-chart/pull/440#issuecomment-1909548798
I already merged this, but I do have a concern. Since the admin port was added to the existing service that is a load balancer, I guess this expands the attack surface since admin operations are now accessible on the load balancer. @Mortom123 any thoughts on that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] expose admin port of pulsar manager in service [pulsar-helm-chart]
Posted by "Mortom123 (via GitHub)" <gi...@apache.org>.
Mortom123 commented on PR #440:
URL: https://github.com/apache/pulsar-helm-chart/pull/440#issuecomment-1909564493
@lhotari Mhh. You might be right. However I think the admij port gets deactivated / does not listen anymore once the account for the manager is created. But we could also make a second Node Port service I guess?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org