[GitHub] kunal642 commented on a change in pull request #3070: [CARBONDATA-3246]Fix sdk reader issue if batch size is given as zero and vectorRead False.

[GitBox <gi...@apache.org>]

kunal642 commented on a change in pull request #3070: [CARBONDATA-3246]Fix sdk reader issue if batch size is given as zero and vectorRead False.
URL: https://github.com/apache/carbondata/pull/3070#discussion_r248148524
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/scan/result/iterator/AbstractDetailQueryResultIterator.java
 ##########
 @@ -94,6 +94,9 @@
     if (null != batchSizeString) {
       try {
         batchSize = Integer.parseInt(batchSizeString);
+        if (0 >= batchSize) {
 
 Review comment:
   1. This check has to be added in AbstractDetailQueryResultIterator.java because the user can set the value of "carbon.detail.batch.size" as 0. Both cases (SDK and Session) would be handled from here.
   
   2. No need to throw exception as for other cases also default value is used without breaking the flow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services