You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/04/23 19:14:10 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #4108: [pulsar-clients]Save name, type, properties for KeyValueSchema

sijie commented on a change in pull request #4108: [pulsar-clients]Save name, type, properties for KeyValueSchema
URL: https://github.com/apache/pulsar/pull/4108#discussion_r277831080
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/KeyValueSchema.java
 ##########
 @@ -22,6 +22,7 @@
 
 import java.nio.ByteBuffer;
 
+import com.google.gson.Gson;
 
 Review comment:
   @cckellogg what does it matter here?
   
   Gson is already a dependency in pulsar-client. It is not a new dependency. It is already used in AuthenticationBasic.java

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services