[GitHub] [pulsar] epsteina16 opened a new pull request #4768: Expose acknowledgment flushing capabilities at the consumer level

[GitBox <gi...@apache.org>]

epsteina16 opened a new pull request #4768: Expose acknowledgment flushing capabilities at the consumer level
URL: https://github.com/apache/pulsar/pull/4768
 
 
   ### Motivation
   
   In a checkpoint-based system, in which a system waits to send acknowledgements to the Pulsar server until it reaches a checkpoint, it should be able to know that all acknowledgements were sent off at the end of the checkpoint without sacrificing performance. Currently, acknowledgements are by default batched, which improves network performance. To guarantee the above, one would have to disable batching. These changes provide that guarantee without sacrificing network performance.
   
   ### Modifications
   
   Added API call to the consumer for flushing pending batched acknowledgments. Added implementations in ConsumerImpl.java and MultiTopicsConsumerImpl.java.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (yes)
           - Add flushAcknowledgements() to consumer API
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (don't know)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (JavaDocs)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services