You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/06 00:02:19 UTC

[GitHub] [airflow] jedcunningham commented on a diff in pull request #26485: Chart: Default airflow version to 2.4.1

jedcunningham commented on code in PR #26485:
URL: https://github.com/apache/airflow/pull/26485#discussion_r988444224


##########
tests/charts/test_basic_helm_chart.py:
##########
@@ -37,8 +37,7 @@ def _get_values_with_version(self, values, version):
         return values
 
     def _get_object_count(self, version):
-        # TODO remove default from condition after airflow update
-        if version == "2.3.2" or version == "default":
+        if version == "2.3.2":

Review Comment:
   After looking at this again with fresh eyes, I like `if version == "2.3.2"` better than `if version != "default" and semver.VersionInfo.parse(version) < (2, 4)`. Seems more straight forward.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org