You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/13 09:03:38 UTC

[GitHub] [pulsar] aloyszhang opened a new pull request #11301: Admin Tool: fix batch size < 0 erro when peekmessage

aloyszhang opened a new pull request #11301:
URL: https://github.com/apache/pulsar/pull/11301


   Fixes #11300 
   ### Motivation
   This pull request fix the error of `X-Pulsar-batch-size` < 0
   
   ### Modifications
   
   1. fix the logic of caculate `X-Pulsar-batch-size`  to make sure it's the right size of batch message
   2. expose more attribute to Admin Tool command of getMessageById and examineMessage
   3. add test code for these changes
   
   ### Verifying this change
   
   This change added tests in `BrokerEntryMetadataE2ETest.testBatchMessage`
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] BewareMyPower merged pull request #11301: Admin Tool: fix batch size < 0 erro when peekmessage

Posted by GitBox <gi...@apache.org>.
BewareMyPower merged pull request #11301:
URL: https://github.com/apache/pulsar/pull/11301


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] aloyszhang commented on pull request #11301: Admin Tool: fix batch size < 0 erro when peekmessage

Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #11301:
URL: https://github.com/apache/pulsar/pull/11301#issuecomment-880492161


   @BewareMyPower PATL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org