You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2018/11/23 10:01:29 UTC

[GitHub] sruehl commented on a change in pull request #40: Alias registry for opm

sruehl commented on a change in pull request #40: Alias registry for opm
URL: https://github.com/apache/incubator-plc4x/pull/40#discussion_r235884091
 
 

 ##########
 File path: plc4j/protocols/test/src/main/java/org/apache/plc4x/java/mock/PlcMockConnection.java
 ##########
 @@ -55,6 +59,7 @@ public MockDevice getDevice() {
     }
 
     public void setDevice(MockDevice device) {
+        logger.info("Set Mock Devie on Mock Connection " + this + " with device " + device);
 
 Review comment:
   We should use string formatting of slf4j here `"Set Mock Devie on Mock Connection {} with device {}", 
   , this ,device`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services