[GitHub] [hive] ayushtkn commented on a change in pull request #2321: HIVE-25165. Generate & track statistics per event type for incremental load in replication metrics.

[GitBox <gi...@apache.org>]

ayushtkn commented on a change in pull request #2321:
URL: https://github.com/apache/hive/pull/2321#discussion_r645311778



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/ReplLogger.java
##########
@@ -47,4 +48,8 @@ public void dataCopyLog(String message) {
 
   public void setParams(String dbName, String dumpDirectory, long numTables, long numFunctions) {
   }
+
+  public ReplStatsTracker getReplStatsTracker() {

Review comment:
       Added a NoOpReplStatTracker as suggested 

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/event/Stage.java
##########
@@ -35,6 +35,7 @@
   private Map<String, Metric> metrics = new HashMap<>();
   private String errorLogPath;
   private SnapshotUtils.ReplSnapshotCount replSnapshotCount = new SnapshotUtils.ReplSnapshotCount();
+  private String replStats = "";

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org