Three things I want to say (synchronisation, doxyfile, ODBCAppender)

[Christian Adams <ch...@comlet.de>]

Hi,

1.

I wrote a wrapper around log4cxx with 0.9.7. There I could use the 
synchronisation mechanism from log4cxx. Now with the current cvs version 
the class synchronisation is seperated in header and cpp file and not 
DLL exported so I have the linker error that the constructor/destrutor 
from synchronisation class cannot be linked (I use log4cxx as shared 
library). So my Question: Can you do these changes on synchronisation.h 
to use your synchronisation class with the DLL?:

#include "log4cxx/log4cxx.h"

class LOG4CXX_EXPORT synchronized


Or do you have your reasons to do not this?
I did these changes and it works fine for me.
---------------------------------------------------

2.

I found that in the Doxyfile under preprocessor the define's

HAVE_XML
HAVE_ODBC
HAVE_SMTP

were set, but some time ago they changed to

LOG4CXX_HAVE_XML
LOG4CXX_HAVE_ODBC
LOG4CXX_HAVE_SMTP

I think the doxyfile should be changed that way.
-----------------------------------------------------

3.

Currently the ODBCAppender::getConnection() uses the method
SQLDriverConnect() to connect to the DB. But this method only uses the 
url string and not the user or password string.
The url string has to look like that:

"DSN=Human Resources;UID=Smith;PWD=Sesame"
(found on 
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/odbcsql/od_odbc_d_4x4k.asp
)

May be you want to delete setter getter for user and password or at 
least change the documentation to make it easier to use the odbcappender.
---------------------------------------------------------

Please let me know if that is the wrong way to place this information. 
I'm a noob in software development, cvs, mailinglist ... ;-)


Greetings

Christian