You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cclauss <gi...@git.apache.org> on 2018/08/24 09:37:25 UTC
[GitHub] spark pull request #22214: [SPARK-23698][Python] Avoid 'undefined name' by d...
GitHub user cclauss opened a pull request:
https://github.com/apache/spark/pull/22214
[SPARK-23698][Python] Avoid 'undefined name' by defining __version__
## What changes were proposed in this pull request?
Prevent linters from raising __undefined name '\_\_version\_\_'__ by initializing the variable before setting it via a call to __exec()__. This is the last remaining issue related to the work done in #20838
## How was this patch tested?
* $ __python2 -m flake8 . --count --select=E9,F82 --show-source --statistics__
* $ __python3 -m flake8 . --count --select=E9,F82 --show-source --statistics__
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cclauss/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22214.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22214
----
commit a077542e67213c0add6093c0bf8c7568b6cb7b32
Author: cclauss <cc...@...>
Date: 2018-08-24T09:36:07Z
[SPARK-23698][Python] Avoid 'undefined name' by defining __version__
Prevent linters from raising __undefined name '\_\_version\_\_'__ by initializing the variable before setting it via a call to __exec()__. This is the last remaining issue related to the work done in #20838
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22214: [SPARK-23698][Python] Avoid 'undefined name' by defining...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22214
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22214: [SPARK-23698][Python] Avoid 'undefined name' by d...
Posted by cclauss <gi...@git.apache.org>.
Github user cclauss closed the pull request at:
https://github.com/apache/spark/pull/22214
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22214: [SPARK-23698][Python] Avoid 'undefined name' by defining...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22214
**[Test build #95243 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95243/testReport)** for PR 22214 at commit [`a077542`](https://github.com/apache/spark/commit/a077542e67213c0add6093c0bf8c7568b6cb7b32).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22214: [SPARK-23698][Python] Avoid 'undefined name' by defining...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22214
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22214: [SPARK-23698][Python] Avoid 'undefined name' by defining...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22214
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22214: [SPARK-23698][Python] Avoid 'undefined name' by defining...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22214
It should have been better fixed together rather then 3 PRs to fix the same instances.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22214: [SPARK-23698][Python] Avoid 'undefined name' by defining...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22214
**[Test build #95243 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95243/testReport)** for PR 22214 at commit [`a077542`](https://github.com/apache/spark/commit/a077542e67213c0add6093c0bf8c7568b6cb7b32).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22214: [SPARK-23698][Python] Avoid 'undefined name' by defining...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22214
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22214: [SPARK-23698][Python] Avoid 'undefined name' by defining...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22214
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95243/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22214: [SPARK-23698][Python] Avoid 'undefined name' by defining...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22214
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22214: [SPARK-23698][Python] Avoid 'undefined name' by d...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22214#discussion_r212788823
--- Diff: python/setup.py ---
@@ -28,6 +28,7 @@
file=sys.stderr)
sys.exit(-1)
+__version__ = "Unknown" # Prevent linters from raising 'undefined name'
--- End diff --
Shall we simply noqa for `VERSION = __version__`? looks weird we have a version defined as Unknown to fix lint errors.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22214: [SPARK-23698][Python] Avoid 'undefined name' by defining...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/22214
Jenkins, ok to test.
LGTM pending Jenkins.
We should add a follow up to add these linter rules to `./dev/lint-python`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org