You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/21 16:57:16 UTC
[GitHub] [lucene-solr] munendrasn opened a new pull request #1900: [SSK-14036]: Remove explicit distrib=false from /terms handler
munendrasn opened a new pull request #1900:
URL: https://github.com/apache/lucene-solr/pull/1900
* This removes shards, shards.qt, and shard whitelisting checks from TermsComponent. Similar to other components, this check will be done in HttpShardHandler
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] munendrasn commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler
Posted by GitBox <gi...@apache.org>.
munendrasn commented on pull request #1900:
URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696271215
@arafalov
There is one already which I have modified(DistributedTermsComponentTest) - https://github.com/apache/lucene-solr/pull/1900/files#diff-9b9ccbcf271c6320902d92479615f4fbR73
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] arafalov commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler
Posted by GitBox <gi...@apache.org>.
arafalov commented on pull request #1900:
URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696269537
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] munendrasn commented on pull request #1900: [SSK-14036]: Remove explicit distrib=false from /terms handler
Posted by GitBox <gi...@apache.org>.
munendrasn commented on pull request #1900:
URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696242179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #1900:
URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696260676
I'm glad to see this :-)
I think the change of default behavior for users using /terms should be master-only and have a note in `solr-upgrade-notes.adoc`. If you like, you could backport the underlying fix but not the change in default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] munendrasn commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler
Posted by GitBox <gi...@apache.org>.
munendrasn commented on pull request #1900:
URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696263900
>I think the change of default behavior for users using /terms should be master-only and have a note in solr-upgrade-notes.adoc. If you like, you could backport the underlying fix but not the change in default.
At this point, I'm planning to keep this master only but if there is a need will backport the necessary changes to 8x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] munendrasn commented on pull request #1900: [SSK-14036]: Remove explicit distrib=false from /terms handler
Posted by GitBox <gi...@apache.org>.
munendrasn commented on pull request #1900:
URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696242179
@tflobbe I have removed CustomTermsComponentTest as none of the components currently have custom handling of shardWhitelist. Let me know if that should be added back
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] arafalov commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler
Posted by GitBox <gi...@apache.org>.
arafalov commented on pull request #1900:
URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696269537
I can't comment on the code, as I did not understand the shard part. I am happy if the extra parameter (distrib=false) is not needed. I did feel that maybe a test was missing somehow. Is there one that tests that distributed terms work? Especially, since terms handler is explicitly defining the Component Chain to be terms only and nothing else (not even sure if that's relevant, though).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #1900:
URL: https://github.com/apache/lucene-solr/pull/1900#discussion_r493862362
##########
File path: solr/solr-ref-guide/src/major-changes-in-solr-9.adoc
##########
@@ -128,6 +128,8 @@ _(raw; not yet edited)_
* SOLR-14510: The `writeStartDocumentList` in `TextResponseWriter` now receives an extra boolean parameter representing the "exactness" of the numFound value (exact vs approximation).
Any custom response writer extending `TextResponseWriter` will need to implement this abstract method now (instead previous with the same name but without the new boolean parameter).
+* SOLR-14036: Implicit /terms handler now supports distributed search by default, when running in cloud mode.
Review comment:
Reworded to help a user think through upgrading:
```suggestion
* SOLR-14036: Implicit /terms handler now returns terms across all shards in SolrCloud instead of only the local core. Users/apps may be assuming the old behavior. A request can be modified via the standard distrib=false param to only use the local core receiving the request.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] munendrasn merged pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler
Posted by GitBox <gi...@apache.org>.
munendrasn merged pull request #1900:
URL: https://github.com/apache/lucene-solr/pull/1900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] munendrasn merged pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler
Posted by GitBox <gi...@apache.org>.
munendrasn merged pull request #1900:
URL: https://github.com/apache/lucene-solr/pull/1900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #1900:
URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696260676
I'm glad to see this :-)
I think the change of default behavior for users using /terms should be master-only and have a note in `solr-upgrade-notes.adoc`. If you like, you could backport the underlying fix but not the change in default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] arafalov commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler
Posted by GitBox <gi...@apache.org>.
arafalov commented on pull request #1900:
URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696402318
> @arafalov
> There is one already which I have modified(DistributedTermsComponentTest) - https://github.com/apache/lucene-solr/pull/1900/files#diff-9b9ccbcf271c6320902d92479615f4fbR73
Thank you for clarification. I saw that code change, but did not realize it answered my question.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] munendrasn commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler
Posted by GitBox <gi...@apache.org>.
munendrasn commented on pull request #1900:
URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696262897
@joel-bernstein Please review(not able to tags as a reviewer so the ping)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] arafalov commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler
Posted by GitBox <gi...@apache.org>.
arafalov commented on pull request #1900:
URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696402318
> @arafalov
> There is one already which I have modified(DistributedTermsComponentTest) - https://github.com/apache/lucene-solr/pull/1900/files#diff-9b9ccbcf271c6320902d92479615f4fbR73
Thank you for clarification. I saw that code change, but did not realize it answered my question.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] munendrasn commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler
Posted by GitBox <gi...@apache.org>.
munendrasn commented on pull request #1900:
URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-697360102
I have included the changes and upgrade entry. Instead of adding upgrade entry to `solr-upgrade-notes.adoc`, I have added to `major-changes-in-solr-9.adoc` as mentioned the former doc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org