[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1428: MINIFICPP-1648 Input/OutputStreamCallback should use Input/OutputStream instead of BaseStream

[GitBox <gi...@apache.org>]

lordgamez commented on code in PR #1428:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1428#discussion_r991153561


##########
extensions/sftp/processors/FetchSFTP.cpp:
##########
@@ -122,11 +122,11 @@ void FetchSFTP::onTrigger(const std::shared_ptr<core::ProcessContext> &context,
 
   /* Download file */
   try {
-    session->write(flow_file, [&remote_file, &client](const std::shared_ptr<io::BaseStream>& stream) -> int64_t {
+    session->write(flow_file, [&remote_file, &client, &flow_file](const std::shared_ptr<io::OutputStream>& stream) -> int64_t {
       if (!client->getFile(remote_file, *stream)) {
         throw utils::SFTPException{client->getLastError()};
       }
-      return gsl::narrow<int64_t>(stream->size());
+      return gsl::narrow<int64_t>(flow_file->getSize());

Review Comment:
   Changed `getFile` return type in b8d24eaa4f487f7e66b3d4a90f170cc4689931f9



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org