You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "chibenwa (via GitHub)" <gi...@apache.org> on 2023/01/30 09:41:24 UTC

[GitHub] [james-project] chibenwa opened a new pull request, #1416: [PERF] Use UnsynchronizedBufferedInputStream

chibenwa opened a new pull request, #1416:
URL: https://github.com/apache/james-project/pull/1416

   Synchronized methods becomes ore expensive with higher JRE versions (loom) making calling
   `BufferedInputStream::read()` method for each byte prohibitive.
   
   See https://issues.apache.org/jira/projects/IO/issues/IO-786
   
   ![Screenshot from 2023-01-30 09-06-03](https://user-images.githubusercontent.com/6928740/215441811-eb896d5c-8da1-451d-a8c4-34e5a84d3bbb.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on pull request #1416: [PERF] Use UnsynchronizedBufferedInputStream

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1416:
URL: https://github.com/apache/james-project/pull/1416#issuecomment-1409708109

   > EDIT: and are we sure this does not make some tests unstable? I see the first two runs failing on the same test class MemoryTaskManagerTest
   
   Not sure how it relates :-p


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] Arsnael commented on pull request #1416: [PERF] Use UnsynchronizedBufferedInputStream

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1416:
URL: https://github.com/apache/james-project/pull/1416#issuecomment-1409650355

   Read it. Can we see the gain in perf for this change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] Arsnael merged pull request #1416: [PERF] Use UnsynchronizedBufferedInputStream

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael merged PR #1416:
URL: https://github.com/apache/james-project/pull/1416


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org