[GitHub] jackjlli commented on a change in pull request #3516: Deleting extra check for deletedDir during retention

[GitBox <gi...@apache.org>]

jackjlli commented on a change in pull request #3516: Deleting extra check for deletedDir during retention
URL: https://github.com/apache/incubator-pinot/pull/3516#discussion_r234813642
 
 

 ##########
 File path: pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/SegmentDeletionManager.java
 ##########
 @@ -203,13 +203,6 @@ protected void removeSegmentFromStore(String tableNameWithType, String segmentId
    */
   public void removeAgedDeletedSegments(int retentionInDays) {
 
 Review comment:
   nit: It'd be good to log the messages like `Start/Finished removing blablabla` here and at the end of the method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org