[GitHub] [trafficcontrol] ocket8888 edited a comment on pull request #4763: Rewrote postinstall to Python (3.6+)

[GitBox <gi...@apache.org>]

ocket8888 edited a comment on pull request #4763:
URL: https://github.com/apache/trafficcontrol/pull/4763#issuecomment-777947591


   Looks like the error stems from my use of `capture_output`, which was added in Python 3.7. Currently the oldest minor release still receiving security fixes is 3.6 - and that's what's in the CentOS8 `/usr/libexec/` - so we should definitely still support it. Fixed.
   
   Also added support for a Python interpreter at `/usr/libexec/platform-python` - but not Python 2 support. Python 2 is dead and I'm no necromancer. If it would help adoption I would not be in any way opposed to making the script support Python 2 until CentOS 7's end-of-life either after this is merged or through a PR directly to my branch before it's merged, but only if someone else does it because it's work I don't want to do. I like my type hints, and part of the point of doing this rewrite was to eliminate dependencies outside of the standard library which supporting the two cleanly might require (like `future` or `six`) .


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org