You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/12/27 04:05:02 UTC

[GitHub] [beam] yyy1000 opened a new issue, #24785: [Task]: Complete the missing go package version in website

yyy1000 opened a new issue, #24785:
URL: https://github.com/apache/beam/issues/24785

   ### What needs to happen?
   
   Actually, I'm not sure whether it should be done.
   On the website [Quickstart for Go](https://beam.apache.org/get-started/quickstart-go/#run-wordcount), the command is like this:
   `go install github.com/apache/beam/sdks/v2/go/examples/wordcount`
   I think it's better to add the version suffix, like "@ lastest", so newcomers can install that example without specifying it in the go.mod file.
   Similar cases happened in [WordCount Examples](https://beam.apache.org/get-started/wordcount-example/).
   I'm glad to submit a PR with it if it is worth doing.
   
   ### Issue Priority
   
   Priority: 3 (nice-to-have improvement)
   
   ### Issue Components
   
   - [ ] Component: Python SDK
   - [ ] Component: Java SDK
   - [ ] Component: Go SDK
   - [ ] Component: Typescript SDK
   - [ ] Component: IO connector
   - [X] Component: Beam examples
   - [ ] Component: Beam playground
   - [ ] Component: Beam katas
   - [X] Component: Website
   - [ ] Component: Spark Runner
   - [ ] Component: Flink Runner
   - [ ] Component: Samza Runner
   - [ ] Component: Twister2 Runner
   - [ ] Component: Hazelcast Jet Runner
   - [ ] Component: Google Cloud Dataflow Runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Task]: Complete the missing go package version in website [beam]

Posted by "jonathansudhakar1 (via GitHub) via github" <gi...@beam.apache.org>.
jonathansudhakar1 commented on issue #24785:
URL: https://github.com/apache/beam/issues/24785#issuecomment-6690689291

   The Go quickstart already switched to `go run …@latest` in #27207, but the [WordCount walkthrough](https://beam.apache.org/get-started/wordcount-example/) still uses `go install <pkg>` without a version, plus `go get -u golang.org/x/sys/unix`. With current Go (checked with 1.26), both fail outside a module:
   - `go install`: `'go install' requires a version when current directory is not in a module`
   - `go get`: `'go get' is no longer supported outside a module`
   
   I'll send a small PR that applies the quickstart's change to the four Go examples on that page.
   
   .take-issue
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] yyy1000 commented on issue #24785: [Task]: Complete the missing go package version in website

Posted by GitBox <gi...@apache.org>.
yyy1000 commented on issue #24785:
URL: https://github.com/apache/beam/issues/24785#issuecomment-1367936790

   Could anyone help to see whether it should be done?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org