[GitHub] [iceberg] rdblue commented on a diff in pull request #7049: Remove compile-time Hadoop dependency for JDBC and REST catalogs

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #7049:
URL: https://github.com/apache/iceberg/pull/7049#discussion_r1131300709


##########
.palantir/revapi.yml:
##########
@@ -67,9 +67,45 @@ acceptedBreaks:
       justification: "Removing deprecated method"
   "1.1.0":
     org.apache.iceberg:iceberg-core:
+    - code: "java.class.noLongerImplementsInterface"
+      old: "class org.apache.iceberg.jdbc.JdbcCatalog"
+      new: "class org.apache.iceberg.jdbc.JdbcCatalog"
+      justification: "Needed to remove compilation dependency on Hadoop"

Review Comment:
   I think the justification should be that this is a safe change because of type erasure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org