You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/19 09:25:35 UTC
[GitHub] [apisix-helm-chart] PGDream opened a new pull request, #268: nginx connection configurage to values.yaml attrube
PGDream opened a new pull request, #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268
with main snippet don`t modify nginx command `worker_rlimit_nofile、events.worker_connections、events.use`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r853653997
##########
charts/apisix/values.yaml:
##########
@@ -312,6 +312,11 @@ logs:
errorLog: "/dev/stderr"
errorLogLevel: "warn"
+core:
Review Comment:
Use `nginx` will be better, `core` is too generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a diff in pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r860828745
##########
charts/apisix/values.yaml:
##########
@@ -303,14 +303,20 @@ discovery:
# send: 2000
# read: 5000
-# access log and error log configuration
-logs:
Review Comment:
@PGDream plz take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on a diff in pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
PGDream commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r853801382
##########
charts/apisix/values.yaml:
##########
@@ -312,6 +312,11 @@ logs:
errorLog: "/dev/stderr"
errorLogLevel: "warn"
+core:
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
tokers commented on PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#issuecomment-1139432050
> > > > In order to maintain compatibility, we can support both configuration methods at the same time. After 3 versions, remove the old configuration.
> > >
> > >
> > > excuse me, how do it?
> >
> >
> > Let's add the `nginx.log` field but at the same time, don't change the [log parameters](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/README.md#toc15).
>
> that`s it now
See https://github.com/apache/apisix-helm-chart/pull/268/files#r871183026. You need to change all places that refer to the old `log` fields. And mark the `log` fields as deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
tokers commented on PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#issuecomment-1125553406
> @tokers where not change of log parameters?
FYI: https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/templates/configmap.yaml#L166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r871183026
##########
charts/apisix/values.yaml:
##########
@@ -312,6 +312,21 @@ logs:
errorLog: "/dev/stderr"
errorLogLevel: "warn"
+# access and error log configuration
+nginx:
+ core:
+ worker_rlimit_nofile: 20480
+ events:
+ worker_connections: 10620
+ logs:
+ enableAccessLog: true
Review Comment:
I think we need to change all the places that we use the log parameters.
##########
charts/apisix/README.md:
##########
@@ -201,6 +201,20 @@ discovery:
| `logs.errorLog` | Error log path | `/dev/stderr` |
| `logs.errorLogLevel` | Error log level | `warn` |
Review Comment:
Mark these parameters as deprecated. We can remove them after a few releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#issuecomment-1136029076
@PGDream What problem are you having now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
PGDream commented on PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#issuecomment-1117337074
> @PGDream In order to maintain compatibility, we can support both configuration methods at the same time. After 3 versions, remove the old configuration.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
PGDream commented on PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#issuecomment-1138257122
> In order to maintain compatibility, we can support both configuration methods at the same time. After 3 versions, remove the old configuration.
excuse me, how do it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r853928459
##########
charts/apisix/values.yaml:
##########
@@ -303,14 +303,20 @@ discovery:
# send: 2000
# read: 5000
-# access log and error log configuration
-logs:
Review Comment:
This is a broken change, I suggest not introducing it directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] Gallardot commented on a diff in pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
Gallardot commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r865513520
##########
charts/apisix/values.yaml:
##########
@@ -312,6 +312,21 @@ logs:
errorLog: "/dev/stderr"
errorLogLevel: "warn"
+# access and error log configuration
+nginx:
+ core:
+ worker_rlimit_nofile: 20480
+ events:
+ worker_connections: 10620
+ logs:
+ enableAccessLog: true
Review Comment:
How does those `logs` configuration item work in the current version? Maybe need some compatibility code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #268: nginx connection configurage to values.yaml attrube
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#issuecomment-1102575672
plz check the CI errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a diff in pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r853654532
##########
charts/apisix/values.yaml:
##########
@@ -312,6 +312,11 @@ logs:
errorLog: "/dev/stderr"
errorLogLevel: "warn"
+core:
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on a diff in pull request #268: nginx connection configurage to values.yaml attrube
Posted by GitBox <gi...@apache.org>.
PGDream commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r853198423
##########
charts/apisix/values.yaml:
##########
@@ -312,6 +312,12 @@ logs:
errorLog: "/dev/stderr"
errorLogLevel: "warn"
+core:
+ worker_rlimit_nofile: 20480
+ events:
+ worker_connections: 10620
+ use: epoll
Review Comment:
> ref: [ngx_core_module](http://nginx.org/en/docs/ngx_core_module.html#use) and [events](http://nginx.org/en/docs/events.html)
>
> ```
> There is normally no need to specify it explicitly, because nginx will by default use the most efficient method.
> ```
>
> So is it better to default to nil?
yes, nginx auto select `networker process`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
tokers commented on PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#issuecomment-1138330301
> > In order to maintain compatibility, we can support both configuration methods at the same time. After 3 versions, remove the old configuration.
>
> excuse me, how do it?
Let's add the `nginx.log` field but at the same time, don't change the [log parameters](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/README.md#toc15).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
PGDream commented on PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#issuecomment-1124932205
@tokers where not change of log parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
tokers commented on PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#issuecomment-1125814047
>
No. If you don't modify them, what's the point of introducing the `nginx_config.logs`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#issuecomment-1120106433
It's on my queue, I will do the final review today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream closed pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
PGDream closed pull request #268: nginx connection configurage to values.yaml attribute
URL: https://github.com/apache/apisix-helm-chart/pull/268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a diff in pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r854129051
##########
charts/apisix/values.yaml:
##########
@@ -303,14 +303,20 @@ discovery:
# send: 2000
# read: 5000
-# access log and error log configuration
-logs:
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] Gallardot commented on a diff in pull request #268: nginx connection configurage to values.yaml attrube
Posted by GitBox <gi...@apache.org>.
Gallardot commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r852998833
##########
charts/apisix/values.yaml:
##########
@@ -312,6 +312,12 @@ logs:
errorLog: "/dev/stderr"
errorLogLevel: "warn"
+core:
+ worker_rlimit_nofile: 20480
+ events:
+ worker_connections: 10620
+ use: epoll
Review Comment:
Is `epoll` the default value? I don't see this option in the default configuration of APISIX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on a diff in pull request #268: nginx connection configurage to values.yaml attrube
Posted by GitBox <gi...@apache.org>.
PGDream commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r853139772
##########
charts/apisix/values.yaml:
##########
@@ -312,6 +312,12 @@ logs:
errorLog: "/dev/stderr"
errorLogLevel: "warn"
+core:
+ worker_rlimit_nofile: 20480
+ events:
+ worker_connections: 10620
+ use: epoll
Review Comment:
yes， i have see, Now that the scene has been clarified, is the display clearer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
PGDream commented on PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#issuecomment-1139235528
> > > In order to maintain compatibility, we can support both configuration methods at the same time. After 3 versions, remove the old configuration.
> >
> >
> > excuse me, how do it?
>
> Let's add the `nginx.log` field but at the same time, don't change the [log parameters](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/README.md#toc15).
that`s it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on a diff in pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
PGDream commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r853660318
##########
charts/apisix/values.yaml:
##########
@@ -312,6 +312,11 @@ logs:
errorLog: "/dev/stderr"
errorLogLevel: "warn"
+core:
Review Comment:
Is it possible `logs、core` node add parent node `nginx`.
`worker_rlimit_nofile` command ... on `nginx` core model.
example:
```
nginx:
logs:
enableAccessLog
core:
worker_rlimit_nofile:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] Gallardot commented on a diff in pull request #268: nginx connection configurage to values.yaml attrube
Posted by GitBox <gi...@apache.org>.
Gallardot commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r853101315
##########
charts/apisix/values.yaml:
##########
@@ -312,6 +312,12 @@ logs:
errorLog: "/dev/stderr"
errorLogLevel: "warn"
+core:
+ worker_rlimit_nofile: 20480
+ events:
+ worker_connections: 10620
+ use: epoll
Review Comment:
ref: [ngx_core_module](http://nginx.org/en/docs/ngx_core_module.html#use) and [events](http://nginx.org/en/docs/events.html)
```
There is normally no need to specify it explicitly, because nginx will by default use the most efficient method.
```
So is it better to default to nil?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] Gallardot commented on a diff in pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
Gallardot commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r853668950
##########
charts/apisix/values.yaml:
##########
@@ -312,6 +312,11 @@ logs:
errorLog: "/dev/stderr"
errorLogLevel: "warn"
+core:
Review Comment:
> Is it possible `logs、core` node add parent node `nginx`. `worker_rlimit_nofile` command ... on `nginx` core model. example:
>
> ```
> nginx:
> logs:
> enableAccessLog
> core:
> worker_rlimit_nofile:
> ```
good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
PGDream commented on PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#issuecomment-1112814821
> @PGDream In order to maintain compatibility, we can support both configuration methods at the same time. After 3 versions, remove the old configuration.
good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on pull request #268: nginx connection configurage to values.yaml attrube
Posted by GitBox <gi...@apache.org>.
PGDream commented on PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#issuecomment-1102764134
> plz check the CI errors
@tao12345666333 lost reviewer!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
PGDream commented on PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#issuecomment-1126153456
> @PGDream In order to maintain compatibility, we can support both configuration methods at the same time. After 3 versions, remove the old configuration.
> >
>
> No. If you don't modify them, what's the point of introducing the `nginx_config.logs`?
@PGDream In order to maintain compatibility, we can support both configuration methods at the same time. After 3 versions, remove the old configuration. ?
how to solve then above problems?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#issuecomment-1112382161
@PGDream In order to maintain compatibility, we can support both configuration methods at the same time. After 3 versions, remove the old configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
PGDream commented on PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#issuecomment-1125575070
> > @tokers where not change of log parameters?
>
> FYI: https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/templates/configmap.yaml#L166
modify more configure,account upgrade may error..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on a diff in pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
PGDream commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r853660318
##########
charts/apisix/values.yaml:
##########
@@ -312,6 +312,11 @@ logs:
errorLog: "/dev/stderr"
errorLogLevel: "warn"
+core:
Review Comment:
Is it possible `logs、core` node add parent node `nginx`.
`worker_rlimit_nofile` command ... on `nginx` core model.
example:
nginx:
logs:
enableAccessLog
core:
worker_rlimit_nofile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on pull request #268: nginx connection configurage to values.yaml attrube
Posted by GitBox <gi...@apache.org>.
PGDream commented on PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#issuecomment-1102389076
values.yaml add `events.use` purpose `APACHE APISIX ngx_tpl.lua` file override `events.use` command on nginx.conf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on a diff in pull request #268: nginx connection configurage to values.yaml attrube
Posted by GitBox <gi...@apache.org>.
PGDream commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r853065842
##########
charts/apisix/values.yaml:
##########
@@ -312,6 +312,12 @@ logs:
errorLog: "/dev/stderr"
errorLogLevel: "warn"
+core:
+ worker_rlimit_nofile: 20480
+ events:
+ worker_connections: 10620
+ use: epoll
Review Comment:
> the apisix is a linux system, with `epoll` networker model better handle `networker connection`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on a diff in pull request #268: nginx connection configurage to values.yaml attrube
Posted by GitBox <gi...@apache.org>.
PGDream commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r853139772
##########
charts/apisix/values.yaml:
##########
@@ -312,6 +312,12 @@ logs:
errorLog: "/dev/stderr"
errorLogLevel: "warn"
+core:
+ worker_rlimit_nofile: 20480
+ events:
+ worker_connections: 10620
+ use: epoll
Review Comment:
yes， i have see, Now that the scene has been clarified, is the display clearer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on pull request #268: nginx connection configurage to values.yaml attribute
Posted by GitBox <gi...@apache.org>.
PGDream commented on PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#issuecomment-1112201444
This is more convenient for later expansion and structuring. Is it considered possible to change this way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org