You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/02/16 07:51:11 UTC
[kudu-CR] [tests] small cleanup on TxnCommitITest
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17070
Change subject: [tests] small cleanup on TxnCommitITest
......................................................................
[tests] small cleanup on TxnCommitITest
* removed unused variable in the TestRestartingWhileCommitting scenario
* use non-empty transaction (i.e. insert several rows) for the
TestRestartingWhileCommittingAndDeleting scenario
The latter is important to keep the scenario successfully running
when txn participants are registered automatically by tablet servers:
that functionality comes in a follow-up patch.
Change-Id: I47668ef244598edbdd7fcaef88f350f36deabede
---
M src/kudu/integration-tests/txn_commit-itest.cc
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/17070/1
--
To view, visit http://gerrit.cloudera.org:8080/17070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47668ef244598edbdd7fcaef88f350f36deabede
Gerrit-Change-Number: 17070
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tests] small cleanup on TxnCommitITest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17070 )
Change subject: [tests] small cleanup on TxnCommitITest
......................................................................
[tests] small cleanup on TxnCommitITest
* removed unused variable in the TestRestartingWhileCommitting scenario
* use non-empty transaction (i.e. insert several rows) for the
TestRestartingWhileCommittingAndDeleting scenario
The latter is important to keep the scenario successfully running
when txn participants are registered automatically by tablet servers:
that functionality comes in a follow-up patch.
Change-Id: I47668ef244598edbdd7fcaef88f350f36deabede
Reviewed-on: http://gerrit.cloudera.org:8080/17070
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/integration-tests/txn_commit-itest.cc
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I47668ef244598edbdd7fcaef88f350f36deabede
Gerrit-Change-Number: 17070
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tests] small cleanup on TxnCommitITest
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17070 )
Change subject: [tests] small cleanup on TxnCommitITest
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47668ef244598edbdd7fcaef88f350f36deabede
Gerrit-Change-Number: 17070
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 16 Feb 2021 18:41:59 +0000
Gerrit-HasComments: No