You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/12/27 15:24:32 UTC

[GitHub] [rocketmq] horizonzy opened a new pull request #2521: Remove unnecessary implement NettyRequestProcessor

horizonzy opened a new pull request #2521:
URL: https://github.com/apache/rocketmq/pull/2521


   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   Remove unnecessary implement `NettyRequestProcessor`,  it's already implements in `AsyncNettyRequestProcessor`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on pull request #2521: Remove unnecessary implement NettyRequestProcessor

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #2521:
URL: https://github.com/apache/rocketmq/pull/2521#issuecomment-751656299


   @horizonzy Please create an issue before you submit a pull request. Follow the https://github.com/apache/rocketmq/wiki/RIP-14-RocketMQ-Community-Operation-Conventions#pull-request-naming-conventions


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #2521: Remove unnecessary implement NettyRequestProcessor

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2521:
URL: https://github.com/apache/rocketmq/pull/2521#issuecomment-751481715


   
   [![Coverage Status](https://coveralls.io/builds/35956474/badge)](https://coveralls.io/builds/35956474)
   
   Coverage decreased (-0.09%) to 51.849% when pulling **1c60293e6c2a5546224e92ca114d23836df8286b on horizonzy:remove-unnecessary-implement** into **0239421fa59b67c423cf9fcabf5cd6edda0c2076 on apache:develop**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-io commented on pull request #2521: Remove unnecessary implement NettyRequestProcessor

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2521:
URL: https://github.com/apache/rocketmq/pull/2521#issuecomment-751483085


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2521?src=pr&el=h1) Report
   > Merging [#2521](https://codecov.io/gh/apache/rocketmq/pull/2521?src=pr&el=desc) (1c60293) into [develop](https://codecov.io/gh/apache/rocketmq/commit/0239421fa59b67c423cf9fcabf5cd6edda0c2076?el=desc) (0239421) will **increase** coverage by `0.03%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/2521/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv)](https://codecov.io/gh/apache/rocketmq/pull/2521?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #2521      +/-   ##
   =============================================
   + Coverage      45.95%   45.98%   +0.03%     
     Complexity      4316     4316              
   =============================================
     Files            547      547              
     Lines          36236    36236              
     Branches        4808     4808              
   =============================================
   + Hits           16651    16662      +11     
   + Misses         17497    17486      -11     
     Partials        2088     2088              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2521?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...broker/processor/AbstractSendMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/2521/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0Fic3RyYWN0U2VuZE1lc3NhZ2VQcm9jZXNzb3IuamF2YQ==) | `40.58% <ø> (ø)` | `15.00 <0.00> (ø)` | |
   | [...ocketmq/broker/processor/AdminBrokerProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/2521/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0FkbWluQnJva2VyUHJvY2Vzc29yLmphdmE=) | `7.97% <ø> (ø)` | `13.00 <0.00> (ø)` | |
   | [...cketmq/broker/processor/ClientManageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/2521/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0NsaWVudE1hbmFnZVByb2Nlc3Nvci5qYXZh) | `29.03% <ø> (ø)` | `6.00 <0.00> (ø)` | |
   | [...etmq/broker/processor/ConsumerManageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/2521/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0NvbnN1bWVyTWFuYWdlUHJvY2Vzc29yLmphdmE=) | `5.88% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...etmq/broker/processor/EndTransactionProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/2521/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0VuZFRyYW5zYWN0aW9uUHJvY2Vzc29yLmphdmE=) | `51.77% <ø> (ø)` | `10.00 <0.00> (ø)` | |
   | [...etmq/broker/processor/ForwardRequestProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/2521/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0ZvcndhcmRSZXF1ZXN0UHJvY2Vzc29yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ocketmq/broker/processor/PullMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/2521/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1B1bGxNZXNzYWdlUHJvY2Vzc29yLmphdmE=) | `41.28% <0.00%> (ø)` | `19.00 <1.00> (ø)` | |
   | [...cketmq/broker/processor/QueryMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/2521/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1F1ZXJ5TWVzc2FnZVByb2Nlc3Nvci5qYXZh) | `5.71% <0.00%> (ø)` | `2.00 <1.00> (ø)` | |
   | [...cketmq/broker/processor/ReplyMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/2521/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1JlcGx5TWVzc2FnZVByb2Nlc3Nvci5qYXZh) | `54.91% <0.00%> (ø)` | `8.00 <1.00> (ø)` | |
   | [...ocketmq/broker/processor/SendMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/2521/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1NlbmRNZXNzYWdlUHJvY2Vzc29yLmphdmE=) | `41.01% <0.00%> (ø)` | `26.00 <0.00> (ø)` | |
   | ... and [13 more](https://codecov.io/gh/apache/rocketmq/pull/2521/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2521?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2521?src=pr&el=footer). Last update [0239421...1c60293](https://codecov.io/gh/apache/rocketmq/pull/2521?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] horizonzy closed pull request #2521: [ISSUE #2525] Remove unnecessary implement NettyRequestProcessor

Posted by GitBox <gi...@apache.org>.
horizonzy closed pull request #2521:
URL: https://github.com/apache/rocketmq/pull/2521


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org