You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/03 14:52:42 UTC
[GitHub] [flink] LululuAlu opened a new pull request #11003:
[FLINK-15866][core]ClosureCleaner#getSuperClassOrInterfaceName throw NPE
LululuAlu opened a new pull request #11003: [FLINK-15866][core]ClosureCleaner#getSuperClassOrInterfaceName throw NPE
URL: https://github.com/apache/flink/pull/11003
Object type field was not implement Serializable, so checked it as unserialize object, and add check null before call superclass's method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha closed pull request #11003:
[FLINK-15866][core]ClosureCleaner#getSuperClassOrInterfaceName throw NPE
Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #11003: [FLINK-15866][core]ClosureCleaner#getSuperClassOrInterfaceName throw NPE
URL: https://github.com/apache/flink/pull/11003
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11003:
[FLINK-15866][core]ClosureCleaner#getSuperClassOrInterfaceName throw NPE
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11003: [FLINK-15866][core]ClosureCleaner#getSuperClassOrInterfaceName throw NPE
URL: https://github.com/apache/flink/pull/11003#issuecomment-581466184
<!--
Meta data
Hash:72bfe5f8058942fff8d7837938b6f2e9372dae09 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:72bfe5f8058942fff8d7837938b6f2e9372dae09
-->
## CI report:
* 72bfe5f8058942fff8d7837938b6f2e9372dae09 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11003:
[FLINK-15866][core]ClosureCleaner#getSuperClassOrInterfaceName throw NPE
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11003: [FLINK-15866][core]ClosureCleaner#getSuperClassOrInterfaceName throw NPE
URL: https://github.com/apache/flink/pull/11003#issuecomment-581466184
<!--
Meta data
Hash:72bfe5f8058942fff8d7837938b6f2e9372dae09 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147221027 TriggerType:PUSH TriggerID:72bfe5f8058942fff8d7837938b6f2e9372dae09
Hash:72bfe5f8058942fff8d7837938b6f2e9372dae09 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4790 TriggerType:PUSH TriggerID:72bfe5f8058942fff8d7837938b6f2e9372dae09
-->
## CI report:
* 72bfe5f8058942fff8d7837938b6f2e9372dae09 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147221027) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4790)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #11003:
[FLINK-15866][core]ClosureCleaner#getSuperClassOrInterfaceName throw NPE
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #11003: [FLINK-15866][core]ClosureCleaner#getSuperClassOrInterfaceName throw NPE
URL: https://github.com/apache/flink/pull/11003#issuecomment-582406911
This fails because of checkstyle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #11003:
[FLINK-15866][core]ClosureCleaner#getSuperClassOrInterfaceName throw NPE
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #11003: [FLINK-15866][core]ClosureCleaner#getSuperClassOrInterfaceName throw NPE
URL: https://github.com/apache/flink/pull/11003#issuecomment-588271583
I merged this now and fixed the checkstyle problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11003:
[FLINK-15866][core]ClosureCleaner#getSuperClassOrInterfaceName throw NPE
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11003: [FLINK-15866][core]ClosureCleaner#getSuperClassOrInterfaceName throw NPE
URL: https://github.com/apache/flink/pull/11003#issuecomment-581452589
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 72bfe5f8058942fff8d7837938b6f2e9372dae09 (Mon Feb 03 14:54:55 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15866).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services