You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/21 14:09:53 UTC

[GitHub] [superset] villebro commented on a change in pull request #17837: refactor(monorepo): update plugin dependencies

villebro commented on a change in pull request #17837:
URL: https://github.com/apache/superset/pull/17837#discussion_r773166359



##########
File path: superset-frontend/scripts/lernaVersion.sh
##########
@@ -53,11 +53,7 @@ fi
 
 # Get the current tag version
 tag=v$(node -e "process.stdout.write(require('./lerna.json').version)");
-message="chore: publish $tag"
-
-# Update the lock file here
-rm "$rootDir/package-lock.json"
-npm i --package-lock-only
+message="chore(plugins): publish $tag"

Review comment:
       Nit: should this be
   ```suggestion
   message="chore(superset-ui): publish $tag"
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org