You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/23 09:06:33 UTC

[GitHub] [apisix-helm-chart] ntfs32 opened a new pull request #32: fix: dashboard ingress and apisix gateway ingress

ntfs32 opened a new pull request #32:
URL: https://github.com/apache/apisix-helm-chart/pull/32


   fix dashboard ingress apiVersion when kubernetes version in v14 newline bug,
   
   add apisix gateway ingress suppurt, just in default values.yaml, not any ingress defined.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-helm-chart] Junnplus commented on pull request #32: fix: dashboard ingress and apisix gateway ingress

Posted by GitBox <gi...@apache.org>.
Junnplus commented on pull request #32:
URL: https://github.com/apache/apisix-helm-chart/pull/32#issuecomment-795249293


   LGTM, @tokers we can merge this ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-helm-chart] gxthrj merged pull request #32: fix: dashboard ingress and apisix gateway ingress

Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #32:
URL: https://github.com/apache/apisix-helm-chart/pull/32


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-helm-chart] tokers commented on pull request #32: fix: dashboard ingress and apisix gateway ingress

Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #32:
URL: https://github.com/apache/apisix-helm-chart/pull/32#issuecomment-784140358


   @ntfs32 Thanks for your contribution, it looks good to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-helm-chart] tokers commented on pull request #32: fix: dashboard ingress and apisix gateway ingress

Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #32:
URL: https://github.com/apache/apisix-helm-chart/pull/32#issuecomment-795251132


   @gxthrj please take a look when you have time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org