You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/10/12 00:03:13 UTC

[GitHub] [commons-collections] tongxin97 opened a new pull request #190: [COLLECTIONS-769] Fix flaky UnmodifiableMultiValuedMapTest

tongxin97 opened a new pull request #190:
URL: https://github.com/apache/commons-collections/pull/190


   Detailed description: https://issues.apache.org/jira/browse/COLLECTIONS-769
   
   Fix: replace the affected assertions with calls to a helper function that asserts all the added values are still present in the map under test. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] tongxin97 commented on a change in pull request #190: [COLLECTIONS-769] Fix flaky UnmodifiableMultiValuedMapTest

Posted by GitBox <gi...@apache.org>.
tongxin97 commented on a change in pull request #190:
URL: https://github.com/apache/commons-collections/pull/190#discussion_r503004932



##########
File path: src/test/java/org/apache/commons/collections4/multimap/UnmodifiableMultiValuedMapTest.java
##########
@@ -48,6 +48,12 @@ public static Test suite() {
     }
 
     // -----------------------------------------------------------------------
+    private void assertMapContainsAllValues(MultiValuedMap<K, V> map) {

Review comment:
       Sounds good. Updated. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] kinow commented on a change in pull request #190: [COLLECTIONS-769] Fix flaky UnmodifiableMultiValuedMapTest

Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #190:
URL: https://github.com/apache/commons-collections/pull/190#discussion_r502993912



##########
File path: src/test/java/org/apache/commons/collections4/multimap/UnmodifiableMultiValuedMapTest.java
##########
@@ -48,6 +48,12 @@ public static Test suite() {
     }
 
     // -----------------------------------------------------------------------
+    private void assertMapContainsAllValues(MultiValuedMap<K, V> map) {

Review comment:
       @tongxin97 can you add a comment over this method, just to clarify why we needed it, please?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] kinow commented on pull request #190: [COLLECTIONS-769] Fix flaky UnmodifiableMultiValuedMapTest

Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #190:
URL: https://github.com/apache/commons-collections/pull/190#issuecomment-706830473


   Might be because I squashed the commits when merging. I tested it with `mvn` locally after squashing them, and looks like the `master` branch is building OK. But will keep an eye open in case a similar issue happens. Thanks for the heaps up @tongxin97 :+1: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] kinow commented on pull request #190: [COLLECTIONS-769] Fix flaky UnmodifiableMultiValuedMapTest

Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #190:
URL: https://github.com/apache/commons-collections/pull/190#issuecomment-706804214


   I couldn't reproduce the issue, as `Hashmap` always returned the values in order. But I think it may change depending on number of elements in map, JVM implementation, etc. So looks safe to go with this improved version. Merging after the javadoc is added :+1: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #190: [COLLECTIONS-769] Fix flaky UnmodifiableMultiValuedMapTest

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #190:
URL: https://github.com/apache/commons-collections/pull/190#issuecomment-706791564


   
   [![Coverage Status](https://coveralls.io/builds/34092692/badge)](https://coveralls.io/builds/34092692)
   
   Coverage remained the same at 90.127% when pulling **1f964678ef0564517cf8e73124052bdc5a0ba834 on tongxin97:flaky-UnmodifiableMultiValuedMapTest** into **6c35a010ecebeec30275df1e0727dd4b29778370 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] kinow closed pull request #190: [COLLECTIONS-769] Fix flaky UnmodifiableMultiValuedMapTest

Posted by GitBox <gi...@apache.org>.
kinow closed pull request #190:
URL: https://github.com/apache/commons-collections/pull/190


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls commented on pull request #190: [COLLECTIONS-769] Fix flaky UnmodifiableMultiValuedMapTest

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #190:
URL: https://github.com/apache/commons-collections/pull/190#issuecomment-706791564


   
   [![Coverage Status](https://coveralls.io/builds/34091328/badge)](https://coveralls.io/builds/34091328)
   
   Coverage remained the same at 90.127% when pulling **d6cc4e0ed9ae52ebc72ed07aca4a574a67a14de3 on tongxin97:flaky-UnmodifiableMultiValuedMapTest** into **6c35a010ecebeec30275df1e0727dd4b29778370 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] kinow commented on pull request #190: [COLLECTIONS-769] Fix flaky UnmodifiableMultiValuedMapTest

Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #190:
URL: https://github.com/apache/commons-collections/pull/190#issuecomment-706820241


   Merged! Thanks @tongxin97 !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] tongxin97 commented on pull request #190: [COLLECTIONS-769] Fix flaky UnmodifiableMultiValuedMapTest

Posted by GitBox <gi...@apache.org>.
tongxin97 commented on pull request #190:
URL: https://github.com/apache/commons-collections/pull/190#issuecomment-706828172


   @kinow Thanks! I saw there might be an error on merging [here](https://travis-ci.org/github/apache/commons-collections/jobs/734868363). Just want to highlight this in case it is something that needs to be taken care of. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] tongxin97 edited a comment on pull request #190: [COLLECTIONS-769] Fix flaky UnmodifiableMultiValuedMapTest

Posted by GitBox <gi...@apache.org>.
tongxin97 edited a comment on pull request #190:
URL: https://github.com/apache/commons-collections/pull/190#issuecomment-706828172


   @kinow Thanks! I saw there might be an error on merging [here](https://travis-ci.org/github/apache/commons-collections/jobs/734868363). Just want to highlight this in case it is something that needs to be taken care of. 
   
   Update: probably not. I saw your latest commit on Master. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org