You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "AlenkaF (via GitHub)" <gi...@apache.org> on 2024/04/25 06:09:47 UTC
[PR] GH-41356: [Release][Docs] Update post release documentation task to remove the warnings banner for stable version [arrow]
AlenkaF opened a new pull request, #41377:
URL: https://github.com/apache/arrow/pull/41377
### Rationale for this change
With every release dev documentation is moved to `docs/` and becomes stable version of the documentation but the version warnings banner is still present.
### What changes are included in this PR?
This PR removes the banner before the dev docs are copied to the `docs/` folder.
### Are these changes tested?
Not yet.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41356: [Release][Docs] Update post release documentation task to remove the warnings banner for stable version [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #41377:
URL: https://github.com/apache/arrow/pull/41377#issuecomment-2079169882
Aha got it! Thank you @raulcd, will correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41356: [Release][Docs] Update post release documentation task to remove the warnings banner for stable version [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #41377:
URL: https://github.com/apache/arrow/pull/41377#issuecomment-2101948497
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit f6127a6d18af12ce18a0b8b1eac02346721cc399.
None of the specified runs were found on the Conbench server.
The [full Conbench report](https://github.com/apache/arrow/runs/24762328855) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41356: [Release][Docs] Update post release documentation task to remove the warnings banner for stable version [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #41377:
URL: https://github.com/apache/arrow/pull/41377#issuecomment-2097749586
Can't test this change on my M1. Hope you can help @raulcd, when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41356: [Release][Docs] Update post release documentation task to remove the warnings banner for stable version [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #41377:
URL: https://github.com/apache/arrow/pull/41377#issuecomment-2076440596
@raulcd does this change look right to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41356: [Release][Docs] Update post release documentation task to remove the warnings banner for stable version [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #41377:
URL: https://github.com/apache/arrow/pull/41377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41356: [Release][Docs] Update post release documentation task to remove the warnings banner for stable version [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41377:
URL: https://github.com/apache/arrow/pull/41377#issuecomment-2076440570
:warning: GitHub issue #41356 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41356: [Release][Docs] Update post release documentation task to remove the warnings banner for stable version [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #41377:
URL: https://github.com/apache/arrow/pull/41377#issuecomment-2099344510
How about creating a temporary directory for the substitution instead of specifying target paths (`c_glib`, `cpp`, ...) explicitly?
```diff
diff --git a/dev/release/post-08-docs.sh b/dev/release/post-08-docs.sh
index 8050a74a8c..fd5debb760 100755
--- a/dev/release/post-08-docs.sh
+++ b/dev/release/post-08-docs.sh
@@ -72,25 +72,18 @@ fi
# delete current stable docs and restore all previous versioned docs
rm -rf docs/*
git checkout "${versioned_paths[@]}"
+
+rm -rf docs_new
+mkdir docs_new
+pushd docs_new
curl \
--fail \
--location \
--remote-name \
https://apache.jfrog.io/artifactory/arrow/docs/${version}/docs.tar.gz
tar xvf docs.tar.gz
-rm -f docs.tar.gz
-
# Update DOCUMENTATION_OPTIONS.show_version_warning_banner for stable docs
-pushd docs
-find ./ \
- -maxdepth 1 \
- -type f \
- -exec \
- sed -i.bak \
- -e "s/DOCUMENTATION_OPTIONS.show_version_warning_banner = true/DOCUMENTATION_OPTIONS.show_version_warning_banner = false/g" \
- {} \;
-find ./ -name '*.bak' -delete
-find /c_glib /cpp /developers /format /java /python \
+find docs \
-type f \
-exec \
sed -i.bak \
@@ -98,8 +91,8 @@ find /c_glib /cpp /developers /format /java /python \
{} \;
find ./ -name '*.bak' -delete
popd
-git add docs
-git commit -m "[Website] Update warning banner for stable docs"
+mv docs_new/docs/* docs/
+rm -rf docs_new
if [ "$is_major_release" = "yes" ] ; then
previous_series=${previous_version%.*}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41356: [Release][Docs] Update post release documentation task to remove the warnings banner for stable version [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #41377:
URL: https://github.com/apache/arrow/pull/41377#discussion_r1593624565
##########
dev/release/post-08-docs.sh:
##########
@@ -72,13 +72,28 @@ fi
# delete current stable docs and restore all previous versioned docs
rm -rf docs/*
git checkout "${versioned_paths[@]}"
+# Download and untare released docs in a temp folder
Review Comment:
```suggestion
# Download and untar released docs in a temp folder
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org