You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/28 08:55:39 UTC

[GitHub] [spark] zhengruifeng opened a new pull request, #38424: [CONNECT][PYTHON] Fix `Dataframe.head`

zhengruifeng opened a new pull request, #38424:
URL: https://github.com/apache/spark/pull/38424

   ### What changes were proposed in this pull request?
   `head` should return `self.limit(n).toPandas()` instead of `self.toPandas()`
   
   
   ### Why are the changes needed?
   bugfix
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   existing tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] amaliujia commented on pull request #38424: [SPARK-40953][CONNECT][PYTHON] Fix `DataFrame.head` to collect specified number of rows

Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38424:
URL: https://github.com/apache/spark/pull/38424#issuecomment-1296499838

   nice catch!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #38424: [SPARK-40953][CONNECT][PYTHON] Fix `DataFrame.head` to collect specified number of rows

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38424: [SPARK-40953][CONNECT][PYTHON] Fix `DataFrame.head` to collect specified number of rows
URL: https://github.com/apache/spark/pull/38424


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zhengruifeng commented on pull request #38424: [SPARK-40953][CONNECT][PYTHON] Fix `Dataframe.head`

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38424:
URL: https://github.com/apache/spark/pull/38424#issuecomment-1294926943

   @dongjoon-hyun thanks for the reminder😄


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #38424: [SPARK-40953][CONNECT][PYTHON] Fix `DataFrame.head` to collect specified number of rows

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38424:
URL: https://github.com/apache/spark/pull/38424#issuecomment-1296227846

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org