You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:13:16 UTC
[GitHub] [arrow-datafusion] Jimexist opened a new pull request #580: Unvendor archery
Jimexist opened a new pull request #580:
URL: https://github.com/apache/arrow-datafusion/pull/580
# Which issue does this PR close?
Closes #.
# Rationale for this change
install https://arrow.apache.org/docs/developers/archery.html from pypi
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #580: Unvendor archery, clean up old files in dev
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #580:
URL: https://github.com/apache/arrow-datafusion/pull/580#issuecomment-871239448
> @Jimexist `dev/integration-tests.sh` relies on `./dev/build-ballista-docker.sh` and some other scripts transitively. They should be brought back. cc @alamb
see what i can do with https://github.com/apache/arrow-datafusion/pull/648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #580: Unvendor archery
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #580:
URL: https://github.com/apache/arrow-datafusion/pull/580#issuecomment-870249061
> everything under `dev/docker` and `dev/integration-tests.sh`.
i have brought back these files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #580: Unvendor archery, clean up old files in dev
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #580:
URL: https://github.com/apache/arrow-datafusion/pull/580#issuecomment-870595646
My apologies to anyone for whom this messes up their workflow. Onward! 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #580: Unvendor archery, clean up old files in dev
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #580:
URL: https://github.com/apache/arrow-datafusion/pull/580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #580: Unvendor archery
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #580:
URL: https://github.com/apache/arrow-datafusion/pull/580#issuecomment-866847178
I think this is a nice change -- however, it seems to delete everything in `dev` -- and it appears there may be some stuff in there that is used but not part of CI (e.g. the ballista docker files that were changed in https://github.com/apache/arrow-datafusion/pull/597)
@andygrove @edrevo is there some place we can figure out what is used by Ballista?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #580: Unvendor archery
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #580:
URL: https://github.com/apache/arrow-datafusion/pull/580#issuecomment-865870893
This may also need this change: https://github.com/apache/arrow-rs/pull/482/files (as apparently the apache licence header check / RAT was calling archery)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #580: Unvendor archery
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #580:
URL: https://github.com/apache/arrow-datafusion/pull/580#issuecomment-863646775
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/580?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#580](https://codecov.io/gh/apache/arrow-datafusion/pull/580?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (90799c9) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/51e5445fa51cef4f72df5db7804906a729fc5aa6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (51e5445) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #580 +/- ##
=======================================
Coverage 76.02% 76.02%
=======================================
Files 156 156
Lines 27063 27063
=======================================
Hits 20575 20575
Misses 6488 6488
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/580?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/580?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [51e5445...90799c9](https://codecov.io/gh/apache/arrow-datafusion/pull/580?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] edrevo commented on pull request #580: Unvendor archery
Posted by GitBox <gi...@apache.org>.
edrevo commented on pull request #580:
URL: https://github.com/apache/arrow-datafusion/pull/580#issuecomment-866972535
everything under `dev/docker` and `dev/integration-tests.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen commented on pull request #580: Unvendor archery, clean up old files in dev
Posted by GitBox <gi...@apache.org>.
yjshen commented on pull request #580:
URL: https://github.com/apache/arrow-datafusion/pull/580#issuecomment-871090795
@Jimexist `dev/integration-tests.sh` relies on `./dev/build-ballista-docker.sh` and some other scripts transitively. They should be brought back. cc @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #580: Unvendor archery
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #580:
URL: https://github.com/apache/arrow-datafusion/pull/580#issuecomment-870249061
> everything under `dev/docker` and `dev/integration-tests.sh`.
i have brought back these files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org