You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by zhuoliu <gi...@git.apache.org> on 2015/07/10 20:49:01 UTC
[GitHub] storm pull request: [STORM-658] Add doc descriptions for the TOPOL...
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/628
[STORM-658] Add doc descriptions for the TOPOLOGY_ACKER_EXECUTORS
The current doc for ackers is outdated (it is for TOPOLOGY_ACKERS), we need to update the descriptions for TOPOLOGY_ACKER_EXECUTORS in Config.java, Guaranteeing-message-processing.md and Running-topologies-on-a-production-cluster.md.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhuoliu/storm 658
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/628.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #628
----
commit f3bfaa08d359ab2bf6374bf428bbd3658b097ad6
Author: zhuol <zh...@yahoo-inc.com>
Date: 2015-07-10T18:38:06Z
[STORM-658] Add doc descriptions for the TOPOLOGY_ACKER_EXECUTORS
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-658] Add doc descriptions for the TOPOL...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/628#issuecomment-120539193
+1, good explanation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-934] Add doc descriptions for the TOPOL...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/628#issuecomment-121062040
Github mirror catches up ASF now, but it isn't treated as merged.
Actually I modified some commit's log to point proper issue number, and it could be the reason.
@zhuoliu Could you close this PR manually? Thanks in advance!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-934] Add doc descriptions for the TOPOL...
Posted by zhuoliu <gi...@git.apache.org>.
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/628#issuecomment-120970488
Thanks for that, @HeartSaVioR !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-934] Add doc descriptions for the TOPOL...
Posted by zhuoliu <gi...@git.apache.org>.
Github user zhuoliu closed the pull request at:
https://github.com/apache/storm/pull/628
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-658] Add doc descriptions for the TOPOL...
Posted by zhuoliu <gi...@git.apache.org>.
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/628#issuecomment-120642677
Thanks @HeartSaVioR ! Sure, a new issue is created (storm-934).
https://issues.apache.org/jira/browse/STORM-934
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-658] Add doc descriptions for the TOPOL...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/628#issuecomment-120601264
@zhuoliu
Btw, I think we need to create new issue cause STORM-658 is actually wrong.
Could you create new issue? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-934] Add doc descriptions for the TOPOL...
Posted by zhuoliu <gi...@git.apache.org>.
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/628#issuecomment-121063729
Thanks @HeartSaVioR. I see the changes merged to master though no log shows.
No problem, I am closing it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-934] Add doc descriptions for the TOPOL...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/628#issuecomment-120803963
I merged it into master branch at ASF git repos, but seems like Github mirror is out of sync.
I'll resolve issue when mirror keeps up ASF repo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---