You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/22 03:20:28 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #39168: [SPARK-41528][CONNECT][FOLLOW-UP] Do not set null as a string for remote option
HyukjinKwon opened a new pull request, #39168:
URL: https://github.com/apache/spark/pull/39168
### What changes were proposed in this pull request?
This PR is a followup of https://github.com/apache/spark/pull/39041 that avoids to set `null` as string for remote configuration and option.
### Why are the changes needed?
To make the default as the regular PySpark as is. Otherwise, it attempts to create remote SparkSession by default, which later fails because of `null` Spark Connect URL.
### Does this PR introduce _any_ user-facing change?
No, the main code has not be released yet.
It fixes `./bin/pyspark` case.
### How was this patch tested?
Manually tested via:
```bash
./bin/pyspark
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #39168: [SPARK-41528][CONNECT][FOLLOW-UP] Do not set null as a string for remote option
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #39168: [SPARK-41528][CONNECT][FOLLOW-UP] Do not set null as a string for remote option
URL: https://github.com/apache/spark/pull/39168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39168: [SPARK-41528][CONNECT][FOLLOW-UP] Do not set null as a string for remote option
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39168:
URL: https://github.com/apache/spark/pull/39168#issuecomment-1362361655
Please let me go and merge this one to recover the PySpark shall .. Otherwise, the very entry point is broken, and I am 100% sure this is the right fix.
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org