[GitHub] [calcite] danny0405 commented on issue #1321: [CALCITE-3200] Add TEXT Data Type

[GitBox <gi...@apache.org>]

danny0405 commented on issue #1321: [CALCITE-3200] Add TEXT Data Type
URL: https://github.com/apache/calcite/pull/1321#issuecomment-513119350
 
 
   > @XuQianJin-Stars @danny0405
   > Issue says the TEXT can be considered a user defined type and that we shouldn't modify the parser. so then my PR is not suitable, maybe I don't need to improve the code.
   > thanks.
   
   Thanks for you PR @ambition119 , add a new type to calcite-core is really a huge work, it will affect the type assignment rules, the type infer(operand types and return types), so a more safer and lightweight way it to use a alias for type `VARCHAR` which  is a more implementable solution.
   
   Another reason is that the `TEXT` type does not belong to the sql standard, so add it to our exists standard types are not that necessary.
   
   I do approve of you to add a sql dialect data type if we have a way to make it pluggable and have a clear interface with which user can switch to.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services